Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixe web3.eth.accounts encrypt/decrypt lib #1237

Closed
wants to merge 389 commits into from
Closed

Conversation

nicolaslawdune
Copy link
Contributor

#1071
Update crypto library.

frozeman and others added 21 commits October 19, 2017 15:35
* removed privateKey from web3.eth.signTransaction and web3.eth.accounts.signTransaction documentation

* removed privateKey from web3.eth.signTransaction and web3.eth.accounts.signTransaction documentation

* added vscode to gitignore and minor doco change

* Added test to show privateKey can not be passed to accounts.signTransaction

* removed passing of private key

* Added Eth.signTransaction function
renamed accounts.privateToAccount to accounts.privateKeyToAccount
Added missing Contract.options
Added status to TransactionReceipt

* reversing changes so my forked 1.0 branch is in sync with the upstream 1.0 branch
* Fix for Bug #1123

* Trigger travis

* Removed a bogus test for `bytes64`
Docs currently show boolean, but it is returning a string
* Fixes in types definition

* Fix Provider type: implement 'empty' variables to the other providers interfaces to make a OR between them
* First draft of babel+eslint+rollup

* Moved to gulp 4, improved some logging output during builds.

* Tweaks to the build process.

* Fixing the versioning task.

* Created separate copies of the .eslintrc files, one for each package.
* First draft of babel+eslint+rollup

* Moved to gulp 4, improved some logging output during builds.

* Tweaks to the build process.

* Fixing the versioning task.

* Created separate copies of the .eslintrc files, one for each package.

* Started converting the first of the tests to es6.
Started by converting HttpProvider to es6, which led to the conversion of contract.js, eth.sendTransaction.js, and setProvider.js
Enabling ES6 support in Mocha led to fixes in method.buildCall.js and utils.sha3.js
Fixed the problems in test/eth.sendTransaction.js that were causing the error "Transaction was not mined within 50 blocks, please make sure your transaction was properly send. Be aware that it might still be mined!".
There may be deeper issues with the tests in eth.sendTransaction.js, these will require some conversation with Fabian before moving forward.

* Fixing coverage problems by upgrading to nyc (the new istanbul)

* Fixed test failure on node 8
* Converted the rest of the tests to es6

* Switched back to "dot" reporter for mocha.
Removed stray console.error line that should not have been committed.
Removed dead/commented console.log lines elsewhere in the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.