-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step 1 of moving to ES6 #1149
Merged
Merged
Step 1 of moving to ES6 #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozeman
reviewed
Nov 13, 2017
@@ -1,6 +1,6 @@ | |||
**PREVIEW RELEASE** This is a beta preview release with breaking changes! The current stable version is 0.20.0 | |||
|
|||
<img src="https://github.com/ethereum/web3.js/raw/1.0/web3js.jpg" width=200 /> | |||
<img src="./assets/web3js.jpg" width=200 /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order that this is shown in the GitHub readme, as well as NPM readme we need to put here the full URL
frozeman
approved these changes
Nov 13, 2017
Thank you so much for all that effort. i was at devcon3 the last weeks. Sorry for getting to this so late |
frozeman
pushed a commit
that referenced
this pull request
Apr 19, 2018
* First draft of babel+eslint+rollup * Moved to gulp 4, improved some logging output during builds. * Tweaks to the build process. * Fixing the versioning task. * Created separate copies of the .eslintrc files, one for each package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Updated out-of-date devDependencies
Added babel configuration
Removed bower and related files
Added esLint configuration and source annotations
Temoved jsHint configuration and source annotations
Moved graphic assets into assets folder, updated README.md
Switched to Gulp 4
Simplified and modularized the gulp build system.
Added a first-draft of a babel-based transpile step.
The .eslintrc files that are in the root of each package will be removed in future PRs, as each module is updated to ES6 syntax, eventually ending with a single .estlintrc at the root of the project, governing all lintable source.