[intersection-observer] Test isIntersecting change events #7215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Build PASSEDStarted: 2017-08-31 22:18:01 Failing Jobs
View more information about this build on: |
|
@tobytailor Are you able to review this? |
|
w3c-test:mirror |
|
@scottlow @szager-chromium are you able to review this? @nolanlawson can you rebase it so that Travis runs again? |
nolanlawson
force-pushed
the
nolan/intersection-observer
branch
from
e4bf8a3 to
25c616d
Compare
|
rebased ^ |
|
w3c-test:mirror |
foolip
approved these changes
May 17, 2018
There was a problem hiding this comment.
Manually confirmed http://w3c-test.org/submissions/7215/intersection-observer/isIntersecting-change-events.html to be passing in Chrome, Edge and Firefox. Safari fails with "Can't find variable: IntersectionObserver"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test for the change introduced in w3c/IntersectionObserver#245. The main difference with the previous version of the spec is that the observer fires events when
isIntersectingchanges butthresholdsIndexdoes not, which covers some odd edge-adjacency scenarios.On my machine, Chrome 60 and Edge 16 prerelease (e.g. public insider 16275) pass the 5 new tests, whereas Firefox Nightly (57.0a1 2017-08-31) does not. This is to be expected given discussion in w3c/IntersectionObserver#222.
/cc @szager-chromium @tobytailor @scottlow