Fire intersection events on isIntersecting changes #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.bs
Outdated
| holding a number between -1 and the length of the observer's {{IntersectionObserver/thresholds}} property (inclusive). | ||
| holding an {{IntersectionObserver}}, a <dfn attribute for=IntersectionObserverRegistration>previousThresholdIndex</dfn> property | ||
| holding a number between -1 and the length of the observer's {{IntersectionObserver/thresholds}} property (inclusive), and | ||
| a <dfn attribute for=IntersectionObserverRegistration>previousIsIntersecting</dfn> property holding a boolean or <code>undefined</code>. |
There was a problem hiding this comment.
Can we get rid of the "undefined" value for previousIsIntersecting, and just initialize it to "false"? The -1 value for previousThresholdIndex will still serve the purpose of forcing the first notification, so it seems like we can safely make previousIsIntersecting a strict boolean.
There was a problem hiding this comment.
Good catch! Yes, we can keep it strict boolean.
sideshowbarker
pushed a commit
to saschanaz/IntersectionObserver
that referenced
this pull request
Mar 17, 2018
…nts on isIntersecting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222. This change should match Blink's existing behavior and EdgeHTML 16's behavior. See #222 (comment) and #222 (comment) for justification.