IndexedDB: Opera's tests #63
Conversation
|
Hi @velmont, per https://dvcs.w3.org/hg/webapps/rev/76acecfc7c55, Opera has ported Microsoft's tests (#64) with some modification, mostly on formatting. To respect for the original author, I would like to review #64 first with reference to the ported. Agree? |
|
Nah, I don't really see the point. I see you've merget #64 already now, but I guess I can change this one to overwrite those tests now that they're there. You see, these tests all follow the same pattern, and that's a good thing. It makes it easier to understand one test and then get them all. MS' tests are more barebones, so they might be a bit easier to understand at first, but these ones also test much more. Because they set up fail listeners for events that really shouldn't be fired. So these tests found some errors in never-released presto IndexedDB that wouldn't have been caught otherwise. So it's not mostly only on formatting. :) Also, the tests were made after I did a review of the original MS tests, and said everything that was wrong, so yes, the tests you just merged were of a much higher quality than those I originally ported over. All credits should be kept in the files however, with respect to original author, but I think my way makes the tests better and more useful. |
|
OK, agree to make the tests better and more useful. Please go ahead to overwrite those tests in need. Sorry for any inconvenience. |
|
I actually think this way of doing it makes sense and is nice. First comitting MS tests, and then "fixing" them afterwards. Makes everything more transparent :) |
|
Hi @velmont , how about using this PR to port Opera's tests only? And you can make new PRs to 'fix' MS tests. :) |
Combine the functions so that web-platform-tests#63, web-platform-tests#66 ~ web-platform-tests#69 can remove the file. Still keep IndexedDB/support.js use vendor prefix.
- Correct support.js reference path - Replace IDBTransaction.READ_WRITE with "readwrite" as it is obsolete - Remove console.log - Enable commented assertions
|
@velmont , could you please review my commits above? I would like to move Opera's tests in this PR, but seems the system cannot automatically merge it. Thanks. |
|
What commits? I don't see any on this pull request. If you talk about the others those look already merged, or? This PR needs to be rewritten on top of the new master with the tests that already exist there. That is some work to be done. Awesome work for someone new by the way. Because it is detailed and a bit of hard work, but not advanced. |
|
OK, rewrite this pull request as #468; please check that. |
|
Hm. I used the mobile web interface, it seems that one didn't really show me the changes correct. So I've been a bit confused :) But do we have any pull request for the updated MS tests now? |
|
Currently no. I just leave the updated MS tests there in submissions/Opera/Microsoft-port/. Feel free to make pull request for the update since you made them. #468 just touch the files in submissions/Opera/ excluding subdirectories; and I will make more pull requests for the files in these subdirectories, perhaps with some update. Make sense? |
|
Ah, you left the rest, OK. Makes sense :) |
…_properties Pick up testharness settings from parent window for use in the runner
Update doc comments for Stash.
Vendor in py which a dependency of pytest
88c5c5b6bb chore(package): bump version 8b3bc38a24 chore(package): bump version c64fe13a42 chore(package): update deps a0bccdf485 fix "Trailing comma in extended attribute" error (#63) 62633a1025 Remove support for MapClass (no longer valid in WebIDL) (#62) 3a7d1bbe3e Merge pull request #61 from w3c/annotated_types 49ea372ba3 Fix spaces in JSON output for updated test 7488ee661f docs(README): fix markdown. 5530e9fecc Adapt test to support for annotated types a387b679ca Add support for annotated types ffe9400aba Merge pull request #58 from SaschaNaz/namespace 9a154bb963 implement namespace 830d19191f chore(package): bump version e5771f11e8 Revert "style: use U.S. English" 8c712c9cb8 chore(package): bump version 8ee9a85ad8 style: use U.S. English bc7b7c6897 style(lib): beautify code 96699646e1 chore(package): bump version 86ea904cbf chore(package): update dependencies 44d7b22851 Merge pull request #57 from TimothyGu/develop 0b5300ec76 Make writer less strict about generic idlType's type 064622bf59 Add support for records fcb88fb1ac Merge pull request #50 from w3c/refactor a23527043e refactor(webidl.js): move WebIDLParseError c64e97c3b8 Merge pull request #49 from w3c/amd_compat d1e704bd40 feat(lib): add AMD export support (closes #48) 5458831df8 style(writer.js): fix whitespace 481c29427a style(webidl2.js): fix whitespace ed24e286ee chore(package): update deps 2668a8be5f docs(README): fixup markdown highlighting 9df3430244 Merge pull request #47 from mkwtys/fix-default ec61c0a096 Merge branch 'halton-replace_expect' into develop fb59b13c2c Really be deterministic 128d7335bb Remove reliance on undeterministic object key order 7bf2df2276 Confirm support for union in typedef 1b5b83438e Remove test of now invalid nested typdef 2d8cd93bd4 Update location of expect.js library 1ed22de9b5 Correct jsondiffpatch location. a2e2f8e902 Bump microtime to 2.1.1 23b63723e9 Expand writer support 9cc1281a1c Accept wider (but still incomplete) set of allowed syntax for extended attributes. cb04f7777c Identifier allow `-` d9b4989425 Merge pull request #39 from markandrus/develop 1ab320df8d Merge pull request #37 from artillery/develop 524000bfd6 Merge pull request #31 from othree/in-draft 99127088c2 Fix `"default": undefined` 191685b05f Really be deterministic 300b1e0fae Remove reliance on undeterministic object key order 61c8e65035 Confirm support for union in typedef f0cd831c6c Remove test of now invalid nested typdef 77b5e3df87 Update location of expect.js library f84b8e684c Merge pull request #44 from halton/fix_jsondiffpatch b52117cf05 Merge pull request #43 from halton/bump_microtime 65382bf16b Replace expect.js with expct be6c2e21e9 Correct jsondiffpatch location. 0b0fa3e92d Bump microtime to 2.1.1 e470735423 Expand writer support 9e2ccfc940 Accept wider (but still incomplete) set of allowed syntax for extended attributes. 989591f675 Allow trailing comma in enum 9385d07a54 Identifier allow `-` git-subtree-dir: resources/webidl2 git-subtree-split: 88c5c5b6bb675d0d95ae3ec4db3258768d0c8fc0
) 88c5c5b6bb chore(package): bump version 8b3bc38a24 chore(package): bump version c64fe13a42 chore(package): update deps a0bccdf485 fix "Trailing comma in extended attribute" error (#63) 62633a1025 Remove support for MapClass (no longer valid in WebIDL) (#62) 3a7d1bbe3e Merge pull request #61 from w3c/annotated_types 49ea372ba3 Fix spaces in JSON output for updated test 7488ee661f docs(README): fix markdown. 5530e9fecc Adapt test to support for annotated types a387b679ca Add support for annotated types ffe9400aba Merge pull request #58 from SaschaNaz/namespace 9a154bb963 implement namespace 830d19191f chore(package): bump version e5771f11e8 Revert "style: use U.S. English" 8c712c9cb8 chore(package): bump version 8ee9a85ad8 style: use U.S. English bc7b7c6897 style(lib): beautify code 96699646e1 chore(package): bump version 86ea904cbf chore(package): update dependencies 44d7b22851 Merge pull request #57 from TimothyGu/develop 0b5300ec76 Make writer less strict about generic idlType's type 064622bf59 Add support for records fcb88fb1ac Merge pull request #50 from w3c/refactor a23527043e refactor(webidl.js): move WebIDLParseError c64e97c3b8 Merge pull request #49 from w3c/amd_compat d1e704bd40 feat(lib): add AMD export support (closes #48) 5458831df8 style(writer.js): fix whitespace 481c29427a style(webidl2.js): fix whitespace ed24e286ee chore(package): update deps 2668a8be5f docs(README): fixup markdown highlighting 9df3430244 Merge pull request #47 from mkwtys/fix-default ec61c0a096 Merge branch 'halton-replace_expect' into develop fb59b13c2c Really be deterministic 128d7335bb Remove reliance on undeterministic object key order 7bf2df2276 Confirm support for union in typedef 1b5b83438e Remove test of now invalid nested typdef 2d8cd93bd4 Update location of expect.js library 1ed22de9b5 Correct jsondiffpatch location. a2e2f8e902 Bump microtime to 2.1.1 23b63723e9 Expand writer support 9cc1281a1c Accept wider (but still incomplete) set of allowed syntax for extended attributes. cb04f7777c Identifier allow `-` d9b4989425 Merge pull request #39 from markandrus/develop 1ab320df8d Merge pull request #37 from artillery/develop 524000bfd6 Merge pull request #31 from othree/in-draft 99127088c2 Fix `"default": undefined` 191685b05f Really be deterministic 300b1e0fae Remove reliance on undeterministic object key order 61c8e65035 Confirm support for union in typedef f0cd831c6c Remove test of now invalid nested typdef 77b5e3df87 Update location of expect.js library f84b8e684c Merge pull request #44 from halton/fix_jsondiffpatch b52117cf05 Merge pull request #43 from halton/bump_microtime 65382bf16b Replace expect.js with expct be6c2e21e9 Correct jsondiffpatch location. 0b0fa3e92d Bump microtime to 2.1.1 e470735423 Expand writer support 9e2ccfc940 Accept wider (but still incomplete) set of allowed syntax for extended attributes. 989591f675 Allow trailing comma in enum 9385d07a54 Identifier allow `-` git-subtree-dir: resources/webidl2 git-subtree-split: 88c5c5b6bb675d0d95ae3ec4db3258768d0c8fc0
No description provided.