Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebIDL2 #5665

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Update WebIDL2 #5665

merged 2 commits into from
Apr 26, 2017

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented Apr 24, 2017 •
edited by wpt-reviewable-bot
Loading

This change is Reviewable

@jgraham
Squashed 'resources/webidl2/' changes from bd216bcd55..88c5c5b6bb
3afe26c 
88c5c5b6bb chore(package): bump version
8b3bc38a24 chore(package): bump version
c64fe13a42 chore(package): update deps
a0bccdf485 fix "Trailing comma in extended attribute" error (#63)
62633a1025 Remove support for MapClass (no longer valid in WebIDL) (#62)
3a7d1bbe3e Merge pull request #61 from w3c/annotated_types
49ea372ba3 Fix spaces in JSON output for updated test
7488ee661f docs(README): fix markdown.
5530e9fecc Adapt test to support for annotated types
a387b679ca Add support for annotated types
ffe9400aba Merge pull request #58 from SaschaNaz/namespace
9a154bb963 implement namespace
830d19191f chore(package): bump version
e5771f11e8 Revert "style: use U.S. English"
8c712c9cb8 chore(package): bump version
8ee9a85ad8 style: use U.S. English
bc7b7c6897 style(lib): beautify code
96699646e1 chore(package): bump version
86ea904cbf chore(package): update dependencies
44d7b22851 Merge pull request #57 from TimothyGu/develop
0b5300ec76 Make writer less strict about generic idlType's type
064622bf59 Add support for records
fcb88fb1ac Merge pull request #50 from w3c/refactor
a23527043e refactor(webidl.js): move WebIDLParseError
c64e97c3b8 Merge pull request #49 from w3c/amd_compat
d1e704bd40 feat(lib): add AMD export support (closes #48)
5458831df8 style(writer.js): fix whitespace
481c29427a style(webidl2.js): fix whitespace
ed24e286ee chore(package): update deps
2668a8be5f docs(README): fixup markdown highlighting
9df3430244 Merge pull request #47 from mkwtys/fix-default
ec61c0a096 Merge branch 'halton-replace_expect' into develop
fb59b13c2c Really be deterministic
128d7335bb Remove reliance on undeterministic object key order
7bf2df2276 Confirm support for union in typedef
1b5b83438e Remove test of now invalid nested typdef
2d8cd93bd4 Update location of expect.js library
1ed22de9b5 Correct jsondiffpatch location.
a2e2f8e902 Bump microtime to 2.1.1
23b63723e9 Expand writer support
9cc1281a1c Accept wider (but still incomplete) set of allowed syntax for extended attributes.
cb04f7777c Identifier allow `-`
d9b4989425 Merge pull request #39 from markandrus/develop
1ab320df8d Merge pull request #37 from artillery/develop
524000bfd6 Merge pull request #31 from othree/in-draft
99127088c2 Fix `"default": undefined`
191685b05f Really be deterministic
300b1e0fae Remove reliance on undeterministic object key order
61c8e65035 Confirm support for union in typedef
f0cd831c6c Remove test of now invalid nested typdef
77b5e3df87 Update location of expect.js library
f84b8e684c Merge pull request #44 from halton/fix_jsondiffpatch
b52117cf05 Merge pull request #43 from halton/bump_microtime
65382bf16b Replace expect.js with expct
be6c2e21e9 Correct jsondiffpatch location.
0b0fa3e92d Bump microtime to 2.1.1
e470735423 Expand writer support
9e2ccfc940 Accept wider (but still incomplete) set of allowed syntax for extended attributes.
989591f675 Allow trailing comma in enum
9385d07a54 Identifier allow `-`

git-subtree-dir: resources/webidl2
git-subtree-split: 88c5c5b6bb675d0d95ae3ec4db3258768d0c8fc0
@w3c-bots
Copy link

w3c-bots commented Apr 24, 2017 •
edited
Loading

View the complete job log.

Lint

Passed

@w3c-bots
Copy link

w3c-bots commented Apr 24, 2017 •
edited
Loading

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision f1bb3f0
Ignoring 26 changed files:
No files changed

@w3c-bots
Copy link

w3c-bots commented Apr 24, 2017 •
edited
Loading

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision f1bb3f0
Ignoring 26 changed files:
No files changed

@tobie tobie mentioned this pull request Apr 24, 2017
Closed
12 tasks
@jgraham jgraham requested a review from annevk April 26, 2017 12:59
@annevk
Copy link
Member

annevk commented Apr 26, 2017

I don't think I can review this. I'm not familiar with this code at all. @marcosc touched it a few times?

@annevk annevk removed their request for review April 26, 2017 13:17
@jgraham
Copy link
Contributor Author

jgraham commented Apr 26, 2017

@ayg Can you review this?

ayg added a commit to ayg/web-platform-tests that referenced this pull request Apr 26, 2017
@ayg
Fetch: Update IDL to fix syntax error
a18adf8 
Blocks web-platform-tests#5665.
@ayg ayg mentioned this pull request Apr 26, 2017
Merged
@ayg
Copy link
Contributor

ayg commented Apr 26, 2017

I ran all the idlharness tests through Firefox as suggested by @jgraham on IRC, and the only one whose results changed was a syntax error that I submitted a fix for in #5703.

jgraham pushed a commit that referenced this pull request Apr 26, 2017
@ayg @jgraham
Fetch: Update IDL to fix syntax error
984edb0 
Blocks #5665.
@jgraham jgraham merged commit 960a3d2 into master Apr 26, 2017
@plehegar plehegar deleted the webidl2_update branch September 25, 2017 20:42
@gsnedders
Copy link
Member

@jgraham The fact you squash merged this makes git-subtree very confused trying to do another update of WebIDL2. It expects the squash commit to be of the WebIDL2 tree (i.e., with everything at the root), rather than as it is in 960a3d2 which merged this PR. Definitely needs to be landed with a merge commit (potentially manually, rewriting the merge commit message to reference the PR and then pushing directly to master after it's run through CI).

@gsnedders gsnedders mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgraham @w3c-bots @annevk @ayg @gsnedders @wpt-pr-bot