CSSTransitionDiscrete: Fix counter related crashes #38817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 5, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4310132
branch
2 times, most recently
from
a763c0f
to
c5cfe94
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4310132
branch
2 times, most recently
from
f01fa61
to
76c78c1
Compare
1 task
The generated code in CounterIncrement::ApplyValue expects to receive a CSSValueList with a CSSValuePair inside of it, so this patch adds a CSSValuePair to ComputedStyleUtils::ValueForCounterDirectives Bug: 1399631, 1413556 Change-Id: If38d51d026965b2f481a9ed6432ce519587847ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310132 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118697}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4310132
branch
from
76c78c1
to
afe99ff
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code in CounterIncrement::ApplyValue expects to receive a
CSSValueList with a CSSValuePair inside of it, so this patch adds a
CSSValuePair to ComputedStyleUtils::ValueForCounterDirectives
Bug: 1399631, 1413556
Change-Id: If38d51d026965b2f481a9ed6432ce519587847ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310132
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118697}