Skip to content

Commit

Permalink
CSSTransitionDiscrete: Fix counter related crashes
Browse files Browse the repository at this point in the history
The generated code in CounterIncrement::ApplyValue expects to receive a
CSSValueList with a CSSValuePair inside of it, so this patch adds a
CSSValuePair to ComputedStyleUtils::ValueForCounterDirectives

Bug: 1399631, 1413556
Change-Id: If38d51d026965b2f481a9ed6432ce519587847ef
  • Loading branch information
josepharhar authored and chromium-wpt-export-bot committed Mar 5, 2023
1 parent e731a13 commit a763c0f
Showing 1 changed file with 39 additions and 0 deletions.
39 changes: 39 additions & 0 deletions css/css-lists/css-lists-no-interpolation.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<!DOCTYPE html>
<link rel=author href="mailto:jarhar@chromium.org">
<link rel=help href="https://github.com/w3c/csswg-drafts/issues/4441">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/interpolation-testcommon.js"></script>

<body>
<script>
test_no_interpolation({
property: 'counter-increment',
from: 'initial',
to: 'add 123'
});

test_no_interpolation({
property: 'counter-reset',
from: 'initial',
to: 'add 123'
});

test_no_interpolation({
property: 'counter-set',
from: 'initial',
to: 'add 123'
});

test_no_interpolation({
property: 'list-style-position',
from: 'initial',
to: 'inside'
});

test_no_interpolation({
property: 'list-style-type',
from: 'initial',
to: 'square'
});
</script>

0 comments on commit a763c0f

Please sign in to comment.