Remove scroll-to-light-dismiss behavior from popups #33472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 1, 2022
Per [1], we have resolved that scrolling should *not* light dismiss popups. This CL implements that change. [1] openui/open-ui#240 (comment) Bug: 1307772 Change-Id: I8749574733892bc33c1b19af954badb367d24139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564406 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#988054}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3564406
branch
from
698ee42 to
da4b341
Compare
|
Can download ZIP, so retrying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per [1], we have resolved that scrolling should not light
dismiss popups. This CL implements that change.
[1] openui/open-ui#240 (comment)
Bug: 1307772
Change-Id: I8749574733892bc33c1b19af954badb367d24139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564406
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988054}