Rename QueryOptions.select to QueryOptions.postscriptNames, and update the empty list for postscriptNames match no fonts, instead of matching all fonts. #33406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 29, 2022
the empty list for postscriptNames match no fonts, instead of matching all fonts. Change-Id: Id361587a0316af3c7512f28c1e60cb47fe3d7611 Bug: 1310341,1310389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556637 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/main@{#986580}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3556637
branch
from
2bbb7f7 to
9d7590b
Compare
Looks like a transient failure because I can download chromedriver from that URL now. Retrying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Id361587a0316af3c7512f28c1e60cb47fe3d7611
Bug: 1310341,1310389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3556637
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/main@{#986580}