Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two buggy tests, two helper files #101

Closed
wants to merge 6 commits into from
Closed

Two buggy tests, two helper files #101

wants to merge 6 commits into from

Conversation

hallvors
Copy link
Contributor

These PHP helper files don't set the right status text in HTTP responses when running on w3c-test.org, causing a number of tests to give bogus failures. I'm attempting to fix it but have to way to test on w3c-test.org so I'm just crossing fingers..

Also fixed two genuine test bugs.

Hallvord R. M. Steen and others added 3 commits April 18, 2013 16:05
@jgraham
Copy link
Contributor

jgraham commented Apr 22, 2013

https://critic.hoppipolla.co.uk/r/83

Not sure I understand the reasoning behind this change.

@hallvors
Copy link
Contributor Author

which change in particular? The PHP header() stuff? Merely looking at the docs for the third argument http://no1.php.net/manual/en/function.header.php and hoping w3c-test.org will obey :-p

@hallvors
Copy link
Contributor Author

Ops, didn't realise further commits go into the same pull request by default..

@hallvors
Copy link
Contributor Author

I will do another pull request with only the bug fixes. Closing.

@hallvors hallvors closed this Apr 26, 2013
@kojiishi kojiishi mentioned this pull request Sep 16, 2015
Closed
jugglinmike pushed a commit to bocoup/wpt that referenced this pull request Apr 11, 2017
@Ms2ger
Merge pull request web-platform-tests#101 from Ms2ger/idlharness-worker
4681289 
Update idlharness to work in workers; r=jgraham
jgraham pushed a commit that referenced this pull request Apr 13, 2017
@Ms2ger
Merge pull request #101 from w3c/handlers; r=jgraham
5f2235f 
Add some more tests for handlers.
jgraham pushed a commit that referenced this pull request Apr 21, 2017
@sideshowbarker
Merge pull request #101 from w3c/jgraham/chrome_args_check
ee3d537 
Fix Chrome support so that --webdriver-binary is required and --binary is optional
gsnedders added a commit to gsnedders/web-platform-tests that referenced this pull request Nov 3, 2017
@gsnedders
Squashed 'resources/webidl2/' changes from 88c5c5b6bb..8a7ff70664
b73adc3 
8a7ff70664 chore(package): bump version number to 8.1.0
f26e320e49 feat: always add rhs property (web-platform-tests#110)
8fc7b2ea19 docs(README): Removed redundant sections
649e457b78 chore(CHANGELOG): regenerate
c1af872481 chore(package): bump version number to 8.0.1
407aaefc9f Remove m postfix from all_ws() (web-platform-tests#108)
8f7c37ea23 chore(package): bump version number to 8.0
6f86663dbc feat: support mixins + includes statements (web-platform-tests#105)
d1f2352275 docs(README): fix typo
0ecc48607c BREAKING CHANGE: drop creator support (web-platform-tests#101)
4f1aab4e77 chore: drop Node 6 support (web-platform-tests#102)
af08834028 style: Normalize some whitespace to pass wpt's lint (web-platform-tests#99)
e938ba5eea chore(package): bump version number to 7.0
cb85ff1a02 BREAKING CHANGE: argument type should be a string
101d9067ae chore(package): bump version number
67af674490 docs(README): extended attribute type
b4013a14cc feat: give extended attributes a type
d15fcb28a9 Yet another innocuous change for tests
dd01a2ba48 Another innocuous change for tests
706d6251d5 Innocuous change to trigger a cvs.w3.org refresh
31be15dd81 chore(package): update jsondiffpatch
ca6c08ccd8 chore(CHANGELOG): regenerate
8ce266fc02 Use ES2015 syntax for tests (web-platform-tests#88)
7ffef282e1 chore(package): bump version number
9d2071443c BREAKING CHANGE: ret enum value as object (web-platform-tests#87)
8360040a9d chore(package): bump version number
fa4b9a3ef1 BREAKING CHANGE: Use ES2015 syntax (web-platform-tests#84)
4252cef22e chore(package): update deps
d6b17d84a1 chore(package): bump version number
174e47ea6d Check duplicated names (web-platform-tests#80)
981743ad2e remove legacycaller (web-platform-tests#79)
99100d174b Add "sequence" property to IDL Type AST definition (web-platform-tests#76)
23fc13f951 chore(CHANGELOG): regenerate
6b53eb357b chore(package): bump version
dbce4340c7 feat: support TypeWithExtendedAttributes on generics (web-platform-tests#75)
c5facac405 chore(CHANGELOG): regenerate
0077262a8f chore(CHANGELOG): regenerate
bbbab23b3d BREAKING CHANGE: remove serializers (closes web-platform-tests#73) (web-platform-tests#74)
5d7a972728 docs(README): add namespaces (web-platform-tests#70)
1ad592c3bb chore(package): bump version
056f0cbaf8 chore(.travis): test for latest LTS/stable node versions (web-platform-tests#69)
c6ef83e72f chore(pacakge): bump version
f5d777c7ab fix extattr whitespace error (web-platform-tests#68)
112e8feb16 chore(package): bump version + update deps
8ec814b9f3 BREAKING CHANGE: deprecate arrays and exceptions (web-platform-tests#67)

git-subtree-dir: resources/webidl2
git-subtree-split: 8a7ff70664ef54fbca77d9bda660865a369e9ce6
jugglinmike added a commit to bocoup/wpt that referenced this pull request Oct 22, 2019
@jugglinmike
[infra] Integrate with external PR preview system
26f3f6b 
Introduce a GitHub Action to monitor Pull Requests, storing relevant
information in the project's git repository (thus allowing the external
wptpr.live system to publish previews) and creating GitHub Deployments
(thus alerting contributors to the status of the preview). This Action
is triggered on a regular interval.

Introduce a second GitHub Action to monitor the state of the preview
system and communicate the relevant status to contributors via the Pull
Request UI. This Action is triggered for every GitHub Deployment created
in the previously-described Action.

For example, if three Pull Requests are updated, the first GitHub Action
will inspect them all. It will create GitHub Deployments only for the
"trusted" Pull Requests. A new GitHub Action will run for each of the
Deployments, polling the preview website until either the preview is
available or a timeout is reached. This Action will update the
deployment accordingly so that the author of each Pull Request author is
aware of the status of the preview site.

The following flow chart visually describes the same sequence:

                           sync
    web-platform-testsgh-101 (trusted) --->   |
    web-platform-testsgh-102 (untrusted) ->   |
    web-platform-testsgh-103 (trusted) --->   |
                          .----.
                          |sync|--------+---------------------.
                          '----'        |                     |
                                 .-------------.       .-------------.
                                 |deploy web-platform-testsgh-101|       |deploy web-platform-testsgh-103|
                                 '-------------'       '-------------'
                                        |                     |
                                 poll for preview      poll for preview
                                        |                     |
    web-platform-testsgh-101 <------ success ----- preview available     poll for preview
                                                              |
    web-platform-testsgh-103 <------- error --------------------------------- timeout
jugglinmike added a commit to bocoup/wpt that referenced this pull request Nov 11, 2019
@jugglinmike
[infra] Integrate with external PR preview system
c427ebf 
Introduce a GitHub Action to monitor Pull Requests, storing relevant
information in the project's git repository (thus allowing the external
wptpr.live system to publish previews) and creating GitHub Deployments
(thus alerting contributors to the status of the preview). This Action
is triggered on a regular interval.

Introduce a second GitHub Action to monitor the state of the preview
system and communicate the relevant status to contributors via the Pull
Request UI. This Action is triggered for every GitHub Deployment created
in the previously-described Action.

For example, if three Pull Requests are updated, the first GitHub Action
will inspect them all. It will create GitHub Deployments only for the
"trusted" Pull Requests. A new GitHub Action will run for each of the
Deployments, polling the preview website until either the preview is
available or a timeout is reached. This Action will update the
deployment accordingly so that the author of each Pull Request author is
aware of the status of the preview site.

The following flow chart visually describes the same sequence:

                           sync
    web-platform-testsgh-101 (trusted) --->   |
    web-platform-testsgh-102 (untrusted) ->   |
    web-platform-testsgh-103 (trusted) --->   |
                          .----.
                          |sync|--------+---------------------.
                          '----'        |                     |
                                 .-------------.       .-------------.
                                 |deploy web-platform-testsgh-101|       |deploy web-platform-testsgh-103|
                                 '-------------'       '-------------'
                                        |                     |
                                 poll for preview      poll for preview
                                        |                     |
    web-platform-testsgh-101 <------ success ----- preview available     poll for preview
                                                              |
    web-platform-testsgh-103 <------- error --------------------------------- timeout
stephenmcgruer pushed a commit that referenced this pull request Nov 20, 2019
@jugglinmike @stephenmcgruer
[infra] Integrate with external PR preview system (#19838)
990bd8b 
Introduce a GitHub Action to monitor Pull Requests, storing relevant
information in the project's git repository (thus allowing the external
wptpr.live system to publish previews) and creating GitHub Deployments
(thus alerting contributors to the status of the preview). This Action
is triggered on a regular interval.

Introduce a second GitHub Action to monitor the state of the preview
system and communicate the relevant status to contributors via the Pull
Request UI. This Action is triggered for every GitHub Deployment created
in the previously-described Action.

For example, if three Pull Requests are updated, the first GitHub Action
will inspect them all. It will create GitHub Deployments only for the
"trusted" Pull Requests. A new GitHub Action will run for each of the
Deployments, polling the preview website until either the preview is
available or a timeout is reached. This Action will update the
deployment accordingly so that the author of each Pull Request author is
aware of the status of the preview site.

The following flow chart visually describes the same sequence:

                           sync
    gh-101 (trusted) --->   |
    gh-102 (untrusted) ->   |
    gh-103 (trusted) --->   |
                          .----.
                          |sync|--------+---------------------.
                          '----'        |                     |
                                 .-------------.       .-------------.
                                 |deploy gh-101|       |deploy gh-103|
                                 '-------------'       '-------------'
                                        |                     |
                                 poll for preview      poll for preview
                                        |                     |
    gh-101 <------ success ----- preview available     poll for preview
                                                              |
    gh-103 <------- error --------------------------------- timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
html wg-html wg-webapps xhr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallvors @jgraham