Skip to content

Commit

Permalink
Merge pull request #101 from w3c/jgraham/chrome_args_check
Browse files Browse the repository at this point in the history
Fix Chrome support so that --webdriver-binary is required and --binary is optional
  • Loading branch information
sideshowbarker committed May 23, 2015
2 parents 624d896 + ae6dc5f commit ee3d537
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions wptrunner/browsers/chrome.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@


def check_args(**kwargs):
require_arg(kwargs, "binary")
require_arg(kwargs, "webdriver_binary")


def browser_kwargs(**kwargs):
Expand All @@ -35,9 +35,9 @@ def executor_kwargs(test_type, server_config, cache_manager, run_info_data,
executor_kwargs = base_executor_kwargs(test_type, server_config,
cache_manager, **kwargs)
executor_kwargs["close_after_done"] = True
executor_kwargs["capabilities"] = dict(DesiredCapabilities.CHROME.items() +
{"chromeOptions":
{"binary": kwargs["binary"]}}.items())
executor_kwargs["capabilities"] = dict(DesiredCapabilities.CHROME.items())
if kwargs["binary"] is not None:
executor_kwargs["capabilities"]["chromeOptions"] = {"binary": kwargs["binary"]}

return executor_kwargs

Expand Down

0 comments on commit ee3d537

Please sign in to comment.