Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore support for paths in URLs #134

Merged
merged 1 commit into from
May 1, 2023
Merged

fix: restore support for paths in URLs #134

merged 1 commit into from
May 1, 2023

Conversation

LukeWinikates
Copy link
Contributor

addresses #133

This PR restores support for paths in URLs passed to the Wavefront sender.

  • adds a top-level integration test for path support, so that it's less likely to break in the future
  • makes several helper funcs internal
  • moves sender package tests into sender package (so they can call non-public funcs)

@jbooherl
Copy link
Contributor

jbooherl commented May 1, 2023

lgtm

@LukeWinikates LukeWinikates merged commit f767d37 into wavefrontHQ:master May 1, 2023
@LukeWinikates LukeWinikates deleted the fix-path-support branch May 1, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants