Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavefront URL path is stripped with 0.12.0 sdk version #133

Closed
pavanrangain opened this issue Apr 28, 2023 · 3 comments
Closed

Wavefront URL path is stripped with 0.12.0 sdk version #133

pavanrangain opened this issue Apr 28, 2023 · 3 comments

Comments

@pavanrangain
Copy link

We updated telegraf to version 1.26.2 containing update of Wavefront sdk from 0.11.0 to 0.12.0 and telegraf calls to wavefront proxy are now failing with 404.
We use a Client side load balancer to proxy calls to wavefront proxy instances. Hence our Wavefront URL given to teegraf outputs is as below
http://localhost:29999/wavefront-proxy

With 0.12.0 the path in the URL gets stripped and the proxy calls fail with 404

with 0.11.0 the report URL used to be as below
http://localhost:29999/wavefront-proxy/report?f=wavefront

with 0.12.0 the report URL is as below
http://localhost:29999/report?f=wavefront
(the path parameter gets stripped)

the change in #122 seem to have caused the issue
esp these lines https://github.com/wavefrontHQ/wavefront-sdk-go/blob/master/senders/client_factory.go#L145-L146 where host and port are considered but the path in base URL gets stripped off

@LukeWinikates
Copy link
Contributor

@pavanrangain thanks for taking the time to track down those specific lines. I agree with your assessment - the change in #122 unintentionally removed the path handler.

I'll put together a fix and get it released this week.

@LukeWinikates
Copy link
Contributor

@pavanrangain I just opened a pull request with the fix for this issue. Please feel free to have a look and comment if you have any thoughts.

@LukeWinikates
Copy link
Contributor

@pavanrangain I think this is resolved now - I'm going to close this issue, but please reopen it if you're still having problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants