Small fixes #189
Merged
Small fixes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #189 +/- ##
========================================
Coverage 57.99% 57.99%
========================================
Files 27 27
Lines 16052 16052
========================================
Hits 9310 9310
Misses 6742 6742Continue to review full report at Codecov.
|
jryates
approved these changes
Jul 2, 2018
Closed
|
I'd noticed that git-ignore wasn't working perfectly when cleaning the distribution - but it hadn't occurred to me that trailing whitespace was the issue! Thanks. |
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
Small fixes to makefile and gitignore (trailing whitespace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit makes a small fix to README.install to reflect the change (#156) in the make target for running the tests.
The second commit removes trailing whitespace in the gitignore files throughout the repository. Trailing whitespace in the gitignore files was causing some files produced during testing not be ignored.
This brings up the question of how to deal with whitespace. It is common practice to exclude trailing whitespace, usually by configuring the text editor to trim whitespace upon saving. Perhaps it is desirable to trim trailing whitespace throughout the codebase and implement whitespace checking as part of accepting a pull request.