Fix 152 make tests #156
Merged
Fix 152 make tests #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryates
approved these changes
Dec 22, 2017
Merged
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…make_tests Fix 152 make tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #152.
Now there is a
make teststhat runs both serial and parallel tests, andmake test-serialandmake test-parallelfor the two options.For
./clean_tests, I tried withgit archive --format=tar.gz --prefix=wannier90/ HEAD >wannier90.tar.gzand I think it only exports things that are committed. Since it exports also.gitignorefiles, the clean_tests should work - note thatmake cleanonly remove things that are safe, you need to pass the-iflag to clean also files that are generated. This list is obtained from the ignored files by git, and it's triggered bymake veryclean.The issue is probably that
make cleanalso needs themake.incfile that is not there by default, maybe this is the reason why it crashes? But in this case I think it is not a problem, the archive should be 'clean' by default and one does not need to domake cleanon a new archive. So I think this PR solves all points of #152.