-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON Schema of extensions, TD minimal validation reference #373
Conversation
<div data-include='directory.tm.json'></div> | ||
</pre> | ||
<pre class="advisement json" | ||
data-include='directory.tm.json'></pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is change is to remove an extra line-break from the rendered output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I in fact inlined this in the 3-wd publication.
@@ -2033,16 +2033,20 @@ <h4>Listing</h4> | |||
|
|||
</section> | |||
|
|||
<section id="validation" class="normative"> | |||
<section id="exploration-directory-api-things-validation" class="normative"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified left-over generic ID from when validation section was outside of TDD's API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, just make sure there are no duplicate ids introduced (including between sections and assertions, they are all in one namespace)
@@ -2033,16 +2033,20 @@ <h4>Listing</h4> | |||
|
|||
</section> | |||
|
|||
<section id="validation" class="normative"> | |||
<section id="exploration-directory-api-things-validation" class="normative"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, just make sure there are no duplicate ids introduced (including between sections and assertions, they are all in one namespace)
<div data-include='directory.tm.json'></div> | ||
</pre> | ||
<pre class="advisement json" | ||
data-include='directory.tm.json'></pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I in fact inlined this in the 3-wd publication.
It can be used for validating <a>TDs</a> by a <a>TDD</a> | ||
as prescribed in [[[#exploration-directory-api-things-validation]]]. | ||
<pre class="advisement json" | ||
data-include='validation/td-discovery-extensions-json-schema.json'></pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be inlining this in the 3-wd version, data-include is not working sometimes.
So in general looks good, but I think we should update the assertion to explicitly allow either TD 1.0 or TD 1.1 versions. I am ok with merging if my suggested change is made. Also, this PR is against the main branch, but I would like to update the 3-wd version (the resolution we made last week in the main call allows for that). As part of doing that I will be inlining the data-include to make the file self-contained. |
update minimal validation assertion
Related to #371
Closes #99
Preview | Diff