Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Schema of extensions, TD minimal validation reference #373

Merged
merged 6 commits into from
Jul 11, 2022

Conversation

farshidtz
Copy link
Member

@farshidtz farshidtz commented Jul 9, 2022

Related to #371
Closes #99


Preview | Diff

<div data-include='directory.tm.json'></div>
</pre>
<pre class="advisement json"
data-include='directory.tm.json'></pre>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is change is to remove an extra line-break from the rendered output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I in fact inlined this in the 3-wd publication.

@@ -2033,16 +2033,20 @@ <h4>Listing</h4>

</section>

<section id="validation" class="normative">
<section id="exploration-directory-api-things-validation" class="normative">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified left-over generic ID from when validation section was outside of TDD's API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, just make sure there are no duplicate ids introduced (including between sections and assertions, they are all in one namespace)

@farshidtz farshidtz requested a review from mmccool July 9, 2022 11:23
@farshidtz farshidtz mentioned this pull request Jul 9, 2022
@@ -2033,16 +2033,20 @@ <h4>Listing</h4>

</section>

<section id="validation" class="normative">
<section id="exploration-directory-api-things-validation" class="normative">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, just make sure there are no duplicate ids introduced (including between sections and assertions, they are all in one namespace)

index.html Outdated Show resolved Hide resolved
<div data-include='directory.tm.json'></div>
</pre>
<pre class="advisement json"
data-include='directory.tm.json'></pre>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I in fact inlined this in the 3-wd publication.

It can be used for validating <a>TDs</a> by a <a>TDD</a>
as prescribed in [[[#exploration-directory-api-things-validation]]].
<pre class="advisement json"
data-include='validation/td-discovery-extensions-json-schema.json'></pre>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be inlining this in the 3-wd version, data-include is not working sometimes.

@mmccool
Copy link
Contributor

mmccool commented Jul 11, 2022

So in general looks good, but I think we should update the assertion to explicitly allow either TD 1.0 or TD 1.1 versions. I am ok with merging if my suggested change is made. Also, this PR is against the main branch, but I would like to update the 3-wd version (the resolution we made last week in the main call allows for that). As part of doing that I will be inlining the data-include to make the file self-contained.

@mmccool mmccool mentioned this pull request Jul 11, 2022
14 tasks
update minimal validation assertion
@mmccool mmccool merged commit 8c50e8f into w3c:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define requirements and add section for validation
3 participants