-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Gen Digital implementation #84
Conversation
@BigBlueHat please review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skynet2 the id field of the issuers must represent a valid issuer value used by the endpoint. We recommend a did:key.
@sudeshrshetty @PatStLouis's recommendation is correct. You can, however, use |
correct, we recommend did:key to facilitate interop, but you may use any issuer value that is compliant with the specification and should be the controller of the verificationMethod used |
83efc86
to
5baa539
Compare
hi @PatStLouis @BigBlueHat , thanks for the review. PR updated with correct DIDs, please review. Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
chore: use dids feat: add gen ed25519 tag
Hi @PatStLouis can you please review the PR we made the change that requested |
@PatStLouis Can you please generate latest interop report. We are targeting below test suites, https://w3c.github.io/vc-data-model-2.0-test-suite/ |
feat: add Gen Digital implementation