Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gen Digital implementation #84

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

skynet2
Copy link
Contributor

@skynet2 skynet2 commented Dec 2, 2024

feat: add Gen Digital implementation

@sudeshrshetty
Copy link

@BigBlueHat please review and merge

Copy link
Contributor

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skynet2 the id field of the issuers must represent a valid issuer value used by the endpoint. We recommend a did:key.

@BigBlueHat
Copy link
Member

@sudeshrshetty @PatStLouis's recommendation is correct. You can, however, use urn:uuid: prefixed UUIDs...but these all need to be URIs (of which URNs and DIDs are a subset). did:key is preferred, though.

@PatStLouis
Copy link
Contributor

PatStLouis commented Dec 3, 2024

correct, we recommend did:key to facilitate interop, but you may use any issuer value that is compliant with the specification and should be the controller of the verificationMethod used

@skynet2 skynet2 force-pushed the add-gen branch 2 times, most recently from 83efc86 to 5baa539 Compare December 3, 2024 22:35
@skynet2 skynet2 requested a review from PatStLouis December 3, 2024 22:35
@skynet2
Copy link
Contributor Author

skynet2 commented Dec 3, 2024

hi @PatStLouis @BigBlueHat , thanks for the review.
For this issuers\verifeirs we are using did:web.

PR updated with correct DIDs, please review.

Thanks,
Stas

Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

chore: use dids

feat: add gen ed25519 tag
@fqutishat
Copy link

fqutishat commented Dec 5, 2024

Hi @PatStLouis can you please review the PR we made the change that requested

@PatStLouis PatStLouis merged commit a7cc6d8 into w3c:main Dec 5, 2024
@sudeshrshetty
Copy link

sudeshrshetty commented Dec 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants