Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GenDigital implementation #116

Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat: add GenDigital implementation #116

merged 3 commits into from
Dec 5, 2024

Conversation

skynet2
Copy link
Contributor

@skynet2 skynet2 commented Dec 2, 2024

No description provided.

@sudeshrshetty
Copy link

@BigBlueHat please review and merge

@BigBlueHat
Copy link
Contributor

@skynet2 @sudeshrshetty same thing needed as on w3c/vc-test-suite-implementations#84 (comment)

The id needs to be a URI--ideally a did:key.

@skynet2
Copy link
Contributor Author

skynet2 commented Dec 4, 2024

hi @BigBlueHat ,
Updated, please review.

Thanks,
Stas

PatStLouis
PatStLouis approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@PatStLouis PatStLouis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skynet2 fyi the BitstringStatusList test suites have migrated to the w3c and don't need to be duplicated here as you have included them in the w3c implementations. Otherwise this looks good!

@BigBlueHat
Copy link
Contributor

@skynet2 fyi the BitstringStatusList test suites have migrated to the w3c and don't need to be duplicated here as you have included them in the w3c implementations. Otherwise this looks good!

Can you remove the BitstringStatusList entries? Those are covered by your other PR: w3c/vc-test-suite-implementations#84

Otherwise, this looks good!

BigBlueHat
BigBlueHat requested changes Dec 4, 2024
View reviewed changes
implementations/GenDigital.json Outdated Show resolved Hide resolved
implementations/GenDigital.json Outdated Show resolved Hide resolved
skynet2 and others added 2 commits December 5, 2024 14:52
@skynet2 @BigBlueHat
Update implementations/GenDigital.json
7516285 
Co-authored-by: BigBlueHat <byoung@bigbluehat.com>
@skynet2 @BigBlueHat
Update implementations/GenDigital.json
731143c 
Co-authored-by: BigBlueHat <byoung@bigbluehat.com>
@skynet2 skynet2 requested a review from BigBlueHat December 5, 2024 13:56
@skynet2
Copy link
Contributor Author

skynet2 commented Dec 5, 2024

hi @BigBlueHat ,
Thanks for the patch. I applied it.

Thanks,
Stas

@fqutishat
Copy link

Hi @BigBlueHat can you please review the PR we made the change that requested

@PatStLouis PatStLouis merged commit c58924b into w3c-ccg:main Dec 5, 2024
@sudeshrshetty
Copy link

@PatStLouis Can you please generate latest interop report for vc-api issuer & verifier test suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatStLouis PatStLouis PatStLouis approved these changes

@BigBlueHat BigBlueHat Awaiting requested review from BigBlueHat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skynet2 @sudeshrshetty @BigBlueHat @fqutishat @PatStLouis