-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin production rule definition #11
Conversation
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
…c-jwt into feat/begin-define-production-rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several suggestions - some normative - some editorial.
The issue was discussed in a meeting on 2022-10-19
View the transcript2.6. Begin production rule definition (pr vc-jwt#11)See github pull request vc-jwt#11. Orie Steele: there are changes requested on this. |
@selfissued I have addressed your feedback, let me know if you have additional concerns. |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
I will need to update this based on the resolutions for |
The issue was discussed in a meeting on 2022-10-26
View the transcript1.5. Begin production rule definition (pr vc-jwt#11)See github pull request vc-jwt#11. Orie Steele: That had comments / changes requested by Mike Jones, I believe I addressed them.. Michael Jones: Do you want to talk about the issues?. Orie Steele: I was just doing PRs.. Michael Jones: Thank you, that's fine, that's to TallTed for the recent approval.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to beef up the language about inclusion of alg
as a required header parameter, but we could do that in a separate PR.
I believe I have addressed all comments, I'd like to merge soon. @selfissued would you be willing to press the button? |
The issue was discussed in a meeting on 2022-11-02
View the transcript1.5. Begin production rule definition (pr vc-jwt#11)See github pull request vc-jwt#11. Orie Steele: VC-JWT still has PR 11 open. Michael Jones: given that poll taken on previous call, there seems to be validFrom and validUntil.
Orie Steele: intention was not make any changes, only document what was already required.
Orie Steele: i don't thing we should coming with those changes in the PR. Michael Jones: ok, then i think i can approve. |
Open since august... only 1 approval... perhaps we should pause this work item? |
I'm withdrawing this PR, until the WG decides they want to focus on this work item. |
The issue was discussed in a meeting on 2022-11-30
View the transcript2.4. Begin production rule definition (pr vc-jwt#11)See github pull request vc-jwt#11. Orie Steele: has only one approval -- could indicate general lack of interest and focus on other issues - perhaps pause?.
David Chadwick: lots of interest in JWT- like at JFF plugfest. Lack of time but also implementors are getting it to work ok without so many errors as thought..
David Chadwick: what is the difference between a credential and a verifiable credential- add topic to future agenda please?. Kristina Yasuda: chairs will discuss how to resolve that.
Michael Jones: agree with DavidC that there's a lot of interest in vc-jwt but doesn't indicate that there aren't any problems. Orie Steele: issues that remains: 1) mappings to the core data model, 2) concrete documentation on how to define how to obtain a public key to verify a credential..
Orie Steele: should tackle core-data model issues first.
Manu Sporny: agree in pursuing consensus on JWT but new process could negatively affect this work. Implementors could indicate what they support..
Kristina Yasuda: This work can happen within the process. Thank you for raising this topic. Chairs will discuss.. |
I think the whole section
should be removed and the new JWT-VC spec should create the JWT independently of the contents of the VC or VP. In other words the signer of the JWT does not need to be the issuer of the VC but is whoever the signing entity is. Similarly the expiry date of the JWT is independent of the expirationDate of the credential. I think the new rules should be as follows exp MUST represent the expiration date of the JWT (and is independent of the expirationDate of the VC/VP) sub is the most difficult one to decide. First VCs do not need to contain a subject.id property, so the current text cannot always apply. So we could say something like "sub MUST represent the subject of the JWT. Normally this will be the subject identifier of the VC or the holder identifier of the VP, but it could be a local identifier used by the issuer to identify the subject". Comments? |
A topic for an issue probably... The goal of this PR was to clarify the existing behavior, not introduce new behavior. |
V2 is allowed to make breaking changes and this is what I am proposing for the JWT spec. I think we all agree that the current v1.1 spec is problematical (or even broken) so whilst I can see the point in clarifying how v1.1 should work (as Implementation Guidelines to v1.1) I think v2 should fix things based on the v2 DM (which will also have breaking changes with v1.1) |
@David-Chadwick indeed, v2 can make breaking changes... thats not the intention of this PR. This PR attempts to show exactly how broken v1.1 is, so that we can decide where to break from it for V2. |
@brentzundel @Sakurann can we please merge this PR. |
Now you have confused me. Surely this document is for the v2 DM only? If so then why are we creating v1.1 PRs in it? If you want clarifying text for v1.1 then you should do a PR on that document shouldn't you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should merge this PR at this point. I just re-reviewed it and it is purely editorial.
The intention of the Pull Request is to simply define the existing production rules in greater detail, this PR is supposed to be editorial, I am not trying to change any of the existing behavior.
Preview | Diff