-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address the alg
language per the comment here
#37
Comments
+1
I think alg = none should not be allowed. what is the point of using verifiable credentials if there is no integrity protection.. |
I agree with you, but the VCWG decided to define VPs exactly this way. If this document forbids I think it's probably worth accepting the deviation there are explicitly forbid |
What are those use-cases? (Or where can I read them up?) alg=none in VP-JWT does not make sense to me. What kind of information in a presentation is useful without a cryptographic holder binding that VP-JWT gives? Just send VC-JWT instead of an unsigned VP-JWT, no? alg=none in VC-JWT also does not make much sense, but I am more willing to accept there might be issuers who want to reuse the syntax of VC-data-model (but than why not sign...) |
https://www.w3.org/TR/vc-data-model/#presentations-0 ^ basically how does vc-jwt support this use case... its ok if it doesn't... but better to be explicit about this.
Agreed, also, its probably illegal... depending on your definiton of "external proof". |
@Sakurann recent PRs elaborated on this in great detail, based on conformance to the normative requirements of the core data model... please review. Due to the core data model stating But I am happy to discuss in depth. |
I'm marking pending close, on the offhand chance, folks doing the review, feel the current text is sufficient. |
Marked pending close over 1 week ago, closing. |
#11 (review)
The text was updated successfully, but these errors were encountered: