Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #70: Note srclang hint to address i18n comment #99

Merged
merged 2 commits into from
Aug 25, 2017
Merged

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Aug 24, 2017

index.html Outdated
<p class="note">
The <a>user agent</a> can use the <a><code>srclang</code></a>
attribute of the <a><code>track</code></a> element as a hint of
the language of the text track data to identify a <a>compatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "to help identify" ?

@markafoltz
Copy link
Contributor

👍

@tidoust tidoust mentioned this pull request Aug 25, 2017
17 tasks
@anssiko
Copy link
Member Author

anssiko commented Aug 25, 2017

Addressed @mfoltzgoogle's editorial comments in 951b074

I'll merge given we got @mfoltzgoogle's explicit review (thanks!) and also @tidoust's 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants