Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n-related informative notes about locale passing between devices #100

Merged
merged 3 commits into from
Aug 28, 2017

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Aug 25, 2017

As discussed in #66, the first note encourages the user agent to render user friendly names for the remote playback device, using its locale and text direction; the second note encourages the user agent to pass locale information to the remote playback device so that it may adjust its behavior accordingly.


Preview | Diff

As discussed in w3c#66, the first note encourages the user agent to render user
friendly names for the remote playback device, using its locale and text
direction; the second note encourages the user agent to pass locale information
to the remote playback device so that it may adjust its behavior accordingly.
@tidoust tidoust mentioned this pull request Aug 25, 2017
17 tasks
index.html Outdated
functions to locale-specific attributes that reflect the user's
preferences.
</div>
<div class="note">
The user agent SHOULD pause local audio and video output of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The user agent is expected to pause"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, no, that's addressed in #102 (and actually, that's the note that gets dropped in #102, to make this text fully normative)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then we're all good.

@anssiko
Copy link
Member

anssiko commented Aug 25, 2017

One minor change from "SHOULD" to "is expected to" in a note, otherwise this looks great. Thanks!

@anssiko
Copy link
Member

anssiko commented Aug 25, 2017

(Please omit #100 (comment), since that note is being dropped in #102.)

Copy link
Contributor

@markafoltz markafoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, optional comments to address.

index.html Outdated
permission</em>).
permission</em>). The user agent is encouraged to render user
friendly names of available devices, using their locale and text
direction when they are known.
Copy link
Contributor

@markafoltz markafoltz Aug 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Presentation API text is more specific, suggesting that the locale and text direction originate from the remote playback device (not necessarily the preferences of the user agent displaying the name).

https://w3c.github.io/presentation-api/#selecting-a-presentation-display

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've slightly updated the text to clarify the message (for once, we cannot encourage the user agent to render "user friendly names" without clarifying that we're not expecting the user agent to invent user friendly names but rather to use the ones it has discovered).

index.html Outdated
@@ -1177,6 +1179,13 @@
sync (unless <a>media mirroring</a> is used).
</div>
<div class="note">
The user agent is encouraged to pass locale information to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "locale and text direction information"? Usually the latter is implied by the former, but text direction is called out in the other note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

index.html Outdated
@@ -1177,6 +1179,13 @@
sync (unless <a>media mirroring</a> is used).
</div>
<div class="note">
The user agent is encouraged to pass locale information to the
<a>remote playback device</a> when possible, so that the <a>remote
playback device</a> may adjust its user interface and operational
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth describing how this interacts with default text track selection. For example the remote playback device should choose the same default text track as the controlling user agent (given that user agent's locale preferences are sent from the latter to the former). Perhaps this is implied by your comment already though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was meant to be implied, but it seems worth calling out one or two examples of why that information is useful for remote playback devices. I added a sentence of default text track selection, and a note on the HTTP Accept-Language header.

index.html Outdated
<a>remote playback device</a> when possible, so that the <a>remote
playback device</a> may adjust its user interface and operational
functions to locale-specific attributes that reflect the user's
preferences.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Presentation API specifically asks the presentation receiver to set HTTP headers consistent with the controlling user agent's locale.

https://w3c.github.io/presentation-api/#creating-a-receiving-browsing-context

For remote playback, these headers could impact which media resource is fetched by the remote playback device (in the flinging case), if different media resources have locale-specific embedded text cues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment, I included this as an example of locale usage by the remote playback device.

@markafoltz markafoltz merged commit 1156d14 into w3c:gh-pages Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants