Use HTML machinery to fetch manifests #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
commented
Jun 2, 2020
marcoscaceres
force-pushed
the
html_integration
branch
from
f36bdc0 to
01eb85a
Compare
|
Yeah, it solves for a bunch of stuff we hadn't covered in the original obtain algorithm. |
|
I got the MIME registered in HTML as part of my PR as well this AM. |
marcoscaceres
changed the title
marcoscaceres
changed the title
marcoscaceres
changed the title
marcoscaceres
changed the title
|
@marcoscaceres Can you take a look at Dominic’s feedback & let me know who you want to divvy up those tasks? |
3 tasks
marcoscaceres
force-pushed
the
html_integration
branch
from
453126d to
645412d
Compare
marcoscaceres
commented
Jun 22, 2020
kenchris
reviewed
Jun 22, 2020
index.html
Outdated
| <li>is <a>associated with a manifest</a> with at least a | ||
| <code>name</code> member and a suitable icon. | ||
| <li>has a <a>manifest</a> with at least a <code>name</code> member | ||
| and a suitable icon. |
There was a problem hiding this comment.
suitable? in what the UA deems suitable?
|
Blocked on whatwg/html#5581 |
kenchris
reviewed
Jun 22, 2020
kenchris
approved these changes
Jun 22, 2020
marcoscaceres
commented
Jun 22, 2020
marcoscaceres
commented
Jun 22, 2020
marcoscaceres
force-pushed
the
html_integration
branch
from
22308ba to
bab0b11
Compare
Co-authored-by: Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>
marcoscaceres
force-pushed
the
html_integration
branch
from
bab0b11 to
f063c35
Compare
|
All normative text is now in HTML as whatwg/html#5581 was merged. This is now just an editorial refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #891
Closes #778
Closes #826
Closes #884
HTML pull request whatwg/html#5581
This change (choose one):
Commit message:
Use HTML's link relationship machinery to handle all the obtaining. We just deal with processing.
Preview | Diff