Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link type "manifest" to HTML #778

Closed
Malvoz opened this issue Aug 6, 2019 · 12 comments · Fixed by #894
Closed

Add link type "manifest" to HTML #778

Malvoz opened this issue Aug 6, 2019 · 12 comments · Fixed by #894

Comments

@Malvoz
Copy link

Malvoz commented Aug 6, 2019

I'm aware that the link relation was registered almost 5 years ago. However it does not yet show in https://www.iana.org/assignments/link-relations/link-relations.xhtml

I'm asking because whatwg/html#4823 (comment). I don't know if there's anything to be done TBH, asking nonetheless.

Thanks :)

@marcoscaceres
Copy link
Member

I think we need to actually email IANA with the details from the spec. We haven't done that yet 😊

@marcoscaceres marcoscaceres changed the title "manifest" link relation, IANA status? Add "manifest" link relation to HTML Apr 1, 2020
@marcoscaceres marcoscaceres changed the title Add "manifest" link relation to HTML Add link type "manifest" to HTML Apr 1, 2020
@marcoscaceres
Copy link
Member

We need to do two things here... send a PR to the HTML spec to add "Link type "manifest"" and send a PR to: https://github.com/link-relations/registry

@aarongustafson
Copy link
Collaborator

Would you like me to do that @marcoscaceres?

@marcoscaceres
Copy link
Member

That would be amazing. Take a look at Link type “preload” as one to base off. We should end up with something similar in HTML (pointing back to our spec).

@aarongustafson
Copy link
Collaborator

aarongustafson commented May 26, 2020

ToDo: Add to the HTML spec
ToDo: Web Platform Test:

x = document.createElement("link");
x.relList.supports("manifest");

@aarongustafson
Copy link
Collaborator

Related: whatwg/html#5581

@aarongustafson
Copy link
Collaborator

aarongustafson commented Jun 2, 2020

We need to fire an event named load on the link

Otherwise, fire an event named error at el.

@marcoscaceres
Copy link
Member

Actually, I remembered that we decided not to fire the event on load because it reveals if/when the user is installing. It was something that came up a few years ago, so decided not to add it... I'll have to dig up the original conversation.

@aarongustafson
Copy link
Collaborator

PR is validating. Hopefully it’s ready to merge.

@aarongustafson
Copy link
Collaborator

Looks like we are almost ready to merge into HTML, but @annevk would like some additional tests. See whatwg/html#5581 (review)

@aarongustafson
Copy link
Collaborator

Looks like the PR is passing. 🤞🏻 we’ll get it merged soon.

@aarongustafson
Copy link
Collaborator

Awaiting completion of WPTs (#666).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants