-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link type "manifest" to HTML #778
Comments
I think we need to actually email IANA with the details from the spec. We haven't done that yet 😊 |
We need to do two things here... send a PR to the HTML spec to add "Link type "manifest"" and send a PR to: https://github.com/link-relations/registry |
Would you like me to do that @marcoscaceres? |
That would be amazing. Take a look at Link type “preload” as one to base off. We should end up with something similar in HTML (pointing back to our spec). |
ToDo: Add to the HTML spec x = document.createElement("link");
x.relList.supports("manifest")
; |
Related: whatwg/html#5581 |
We need to fire an event named load on the Otherwise, fire an event named error at el. |
Actually, I remembered that we decided not to fire the event on load because it reveals if/when the user is installing. It was something that came up a few years ago, so decided not to add it... I'll have to dig up the original conversation. |
PR is validating. Hopefully it’s ready to merge. |
Looks like we are almost ready to merge into HTML, but @annevk would like some additional tests. See whatwg/html#5581 (review) |
Looks like the PR is passing. 🤞🏻 we’ll get it merged soon. |
Awaiting completion of WPTs (#666). |
I'm aware that the link relation was registered almost 5 years ago. However it does not yet show in https://www.iana.org/assignments/link-relations/link-relations.xhtml
I'm asking because whatwg/html#4823 (comment). I don't know if there's anything to be done TBH, asking nonetheless.
Thanks :)
The text was updated successfully, but these errors were encountered: