Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to DNOTE for new process #416

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Change to DNOTE for new process #416

merged 1 commit into from
Dec 1, 2021

Conversation

xfq
Copy link
Member

@xfq xfq commented Nov 30, 2021

@xfq xfq requested a review from r12a November 30, 2021 09:34
Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem ok, unless we're changing text that would be overwritten by respec(?).

One other thing that could be done at the same time is to remove the paragraph:

If you wish to make comments regarding this document, please raise them as GitHub issues. Only send comments by email if you are unable to raise issues on GitHub (see links below). All comments are welcome.

I have been removing the green note from documents we are producing because these days we don't want comments by email at all. That note was originally added at a time when respec automatically produced text asking for comments by email, and we were trying to convince users to use GH instead. Nowadays, respec doesn't ask for comments by email, so that note is redundant. We could add the text

To make it easier to track comments, please raise separate issues or emails for each comment, and point to the section you are commenting on using a URL for the dated version of the document.

to the body of the Status section, if you like, but i'd recommend removing the note.

@xfq
Copy link
Member Author

xfq commented Dec 1, 2021

Thanks for your review, @r12a. Because GitHub vs email is not directly related to my changes here, I will solve it in a separate PR.

@xfq xfq merged commit 32265e7 into gh-pages Dec 1, 2021
@xfq xfq deleted the xfq/dnote branch December 1, 2021 09:19
@xfq xfq mentioned this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants