Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the title #390

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Change the title #390

merged 1 commit into from
Oct 1, 2021

Conversation

xfq
Copy link
Member

@xfq xfq commented Oct 1, 2021

Pubrules will convert the <br/> in the h1 to -, so add a - here. Otherwise, Pubrules will report an error:

Content of title and h1 do not match. Text of title is 'Requirements for Chinese Text Layout中文排版需求' while h1 is (transformed into) 'Requirements for Chinese Text Layout - 中文排版需求'.

/cc @r12a


Preview | Diff

@xfq xfq merged commit 3384e9a into gh-pages Oct 1, 2021
@xfq xfq deleted the xfq/title branch October 1, 2021 06:34
@r12a
Copy link
Contributor

r12a commented Oct 1, 2021

Hmm. I thought @marcoscaceres changed the respec code some time ago so that it would handle markup inside the <h1>, and handle a different <h1> from the <title>. Has this code been reverted?

I seem to remember that this was needed for the Japanese docs(??)

@xfq
Copy link
Member Author

xfq commented Oct 1, 2021

@r12a You may be talking about w3c/specberus#1146, but what I am solving here is w3c/specberus#1044. I think it may be necessary to file an issue in ReSpec.

@himorin
Copy link

himorin commented Oct 1, 2021

I believe we (JL-TF) need to update many points to match with the updated pubrules, like adding w3cid-s (really possible???), and would do these (right) before the next possible publication of 2nd edition.

@xfq
Copy link
Member Author

xfq commented Oct 1, 2021

himorin added a commit to himorin/jlreq that referenced this pull request Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants