Checkbox Example (Mixed-State): Toggle on keyup to prevent continuous toggling #2722
Conversation
|
It seems the failing test has to do with the toolbar example, where we try to click the font family button in the toolbar and no dropdown menu appears from the button. Is this test flaky? I feel like I'm able to open the dropdown when opening the example in the browser just fine. I guess I would be surprised if this checkbox change caused this to fail. |
|
@ccanash, will you please assign someone to investigate the cause of the failing test? I re-ran all tests, and it continues to fail. |
mcking65
added
bug
mcking65
changed the title
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> subtopic: Checkbox Example (Mixed-State): Toggle on keyup to prevent continuous toggling by sivakusayan · Pull Request #2722 · w3c/aria-practices<jugglinmike> github: https://github.com//pull/2722 <jugglinmike> Matt_King: We've already merged a similar pull request for the two-state checkbox <Jem> rrsagent, make minutes <RRSAgent> I have made the request to generate https://www.w3.org/2023/06/13-aria-apg-minutes.html Jem <jugglinmike> Matt_King: We need volunteers for code review and functional testing <sirib> can we discuss about https://github.com//issues/1233, https://github.com//issues/1947 if you have time <jugglinmike> Jem: I can perform the reviews |
@mcking65 @sivakusayan since w3c/wai-aria-practices#220 has now been merged, I was able to re-run the actions successfully. The link to the preview is now available in the top comment.
There was indeed a flaky regression test. I re-ran it and it now builds without an issue. |
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> subtopic: Checkbox Example (Mixed-State): Toggle on keyup to prevent continuous toggling by sivakusayan · Pull Request #2722 · w3c/aria-practices<jugglinmike> github: https://github.com//pull/2722 <jugglinmike> Matt_King: It seems like someone should have been assigned to review the code <jugglinmike> andrea_cardona: I can review it <jugglinmike> Matt_King: Awesome; I'll assign you right now |
There was a problem hiding this comment.
Thank you @sivakusayan, the changes are working as expected. This is a good improvement to the behavior.
|
With this commit, #2425 is now fully resolved. |
mcking65
modified the milestones:
H1/2023 Content Updates,
2023-08-01 Publication Pull Requests
This is a follow-up PR to #2518 where Checkbox Example (Two State) was changed to only toggle on keyup. I think it makes sense to make the same change to Checkbox Example (Mixed-State) for consistency.
(Just a head's up, this is a resubmitting of #2541)
WAI Preview Link (Last built on Tue, 13 Jun 2023 18:40:15 GMT).