Checkbox Example (Mixed-State): Activate checkbox only on keyup #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution! Unfortunately, we need to hold off for a few weeks because we are in the midst of restructuring the entire repository to better support the current site design, and we need to temporarily stabilize the main branch. Would you mind rebasing this PR after we merge #2417, which I expect will be between December 1 and December 9? |
|
Are you available to re-do this PR? It might be easiest to close and make a new branch off of the current main branch. |
|
Yeah, I don't mind resubmitting this, I'll do that sometime this week 🙂 |
sivakusayan
force-pushed
the
mixedCheckboxToggleOnKeyUp
branch
2 times, most recently
from
1212370
to
fec7032
Compare
|
The new PR is here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #2518 where Checkbox Example (Two State) was changed to only toggle on keyup. I think it makes sense to make the same change to Checkbox Example (Mixed-State) for consistency.