Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in example combobox/aria1.1pattern/grid-combo.html: key "escape" does not close popup #860

Closed
spectranaut opened this issue Aug 27, 2018 · 0 comments · Fixed by #1334
Closed

Bug in example combobox/aria1.1pattern/grid-combo.html: key "escape" does not close popup #860

spectranaut opened this issue Aug 27, 2018 · 0 comments · Fixed by #1334
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.2 Release 1

Comments

@spectranaut
Copy link
Contributor

On the grid-combo example, the "Grid Popup" Keyboard Support table describes the "escape" key interaction as:

  • Closes the grid popup.
  • Sets focus on the textbox.
  • Clears the textbox.

Presently, escape (while focus is on a gridcell) puts focus back on the textbox but does not close the popup or clear the textbox.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Dec 9, 2019
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Dec 9, 2019
zcorpan added a commit that referenced this issue Mar 6, 2020
@zcorpan
Make escape hide the popup if it's shown, regardless of where focus is
bbfe679 
Update the corresponding test to no longer expect a failure.

Fixes #860.
@zcorpan zcorpan mentioned this issue Mar 6, 2020
Merged
7 tasks
@mcking65 mcking65 linked a pull request Mar 17, 2020 that will close this issue
Combobox with grid popup: Make escape key behavior consistent with pattern #1334
Merged
7 tasks
mcking65 added a commit that referenced this issue Mar 17, 2020
@mcking65 @jongund @zcorpan
Combobox with grid popup: Make escape key behavior consistent with pa…
aabf040 
…ttern (pull #1334)

Fixes #860 and #1066:
* Revise Escape key documentation to reflect expected behavior
* updated escape key behavior to match combobox pattern
* Make escape hide the popup if it's shown, regardless of where focus is
* Update the corresponding test to no longer expect a failure (fixes #860).
* Remove comment about failing test

Co-authored-by: Jon <jongund@illinois.edu>
Co-authored-by: Simon Pieters <zcorpan@gmail.com>
michael-n-cooper pushed a commit that referenced this issue Mar 17, 2020
@jongund @zcorpan
Generated by TRAVIS-CI aabf040
5621dfb 
Combobox with grid popup: Make escape key behavior consistent with pattern (pull #1334)

Fixes #860 and #1066:
* Revise Escape key documentation to reflect expected behavior
* updated escape key behavior to match combobox pattern
* Make escape hide the popup if it's shown, regardless of where focus is
* Update the corresponding test to no longer expect a failure (fixes #860).
* Remove comment about failing test

Co-authored-by: Jon <jongund@illinois.edu>
Co-authored-by: Simon Pieters <zcorpan@gmail.com>
carmacleod pushed a commit to carmacleod/aria-practices that referenced this issue Mar 31, 2020
@mcking65 @jongund
@zcorpan @carmacleod
Combobox with grid popup: Make escape key behavior consistent with pa…
36e10fe 
…ttern (pull w3c#1334)

Fixes w3c#860 and w3c#1066:
* Revise Escape key documentation to reflect expected behavior
* updated escape key behavior to match combobox pattern
* Make escape hide the popup if it's shown, regardless of where focus is
* Update the corresponding test to no longer expect a failure (fixes w3c#860).
* Remove comment about failing test

Co-authored-by: Jon <jongund@illinois.edu>
Co-authored-by: Simon Pieters <zcorpan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Combobox with grid popup: Make escape key behavior consistent with pattern w3c/aria-practices
2 participants
@spectranaut @mcking65