Make escape hide the popup if it's shown, regardless of where focus is

Update the corresponding test to no longer expect a failure. Fixes #860.
w3c · Mar 6, 2020 · bbfe679 · bbfe679
1 parent b65526d
commit bbfe679
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/examples/combobox/js/grid-combo.js b/examples/combobox/js/grid-combo.js
@@ -94,16 +94,16 @@ aria.GridCombobox.prototype.handleInputKeyDown = function (evt) {
       );
     }
     else {
-      if (aria.Utils.hasClass(this.grid, 'hidden')) {
+      if (!this.shown) {
         setTimeout((function () {
           // On Firefox, input does not get cleared here unless wrapped in
           // a setTimeout
           this.input.value = '';
         }).bind(this), 1);
       }
-      else {
-        this.hideResults();
-      }
+    }
+    if (this.shown) {
+      this.hideResults();
     }
     return;
   }

diff --git a/test/tests/combobox_grid-combo.js b/test/tests/combobox_grid-combo.js
@@ -544,7 +544,7 @@ ariaTest('Test double escape key press with focus on combobox',
 
 
 // This test fails due to bug: https://github.com/w3c/aria-practices/issues/860
-ariaTest.failing('Test escape key press with focus on popup',
+ariaTest('Test escape key press with focus on popup',
   exampleFile, 'popup-key-escape', async (t) => {
     t.plan(2);