fix: send an object to text renderer rather than the text itself (ela…

…stic#614)
w33ble · May 22, 2018 · 273032f · 273032f
1 parent f51cef3
commit 273032f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/common/types/boolean.js b/common/types/boolean.js
@@ -9,10 +9,11 @@ export const boolean = () => ({
     string: n => String(n),
     number: n => Number(n),
     render: value => {
+      const text = `${value}`;
       return {
         type: 'render',
         as: 'text',
-        value: `${value}`,
+        value: { text },
       };
     },
   },

diff --git a/common/types/number.js b/common/types/number.js
@@ -7,10 +7,11 @@ export const number = () => ({
   to: {
     string: n => String(n),
     render: value => {
+      const text = `${value}`;
       return {
         type: 'render',
         as: 'text',
-        value: `${value}`,
+        value: { text },
       };
     },
     datatable: value => {

diff --git a/common/types/string.js b/common/types/string.js
@@ -6,11 +6,11 @@ export const string = () => ({
   },
   to: {
     number: n => Number(n),
-    render: value => {
+    render: text => {
       return {
         type: 'render',
         as: 'text',
-        value,
+        value: { text },
       };
     },
   },

diff --git a/public/render_functions/text.js b/public/render_functions/text.js
@@ -6,8 +6,8 @@ export const text = () => ({
   displayName: 'Plain Text',
   help: 'Render output as plain text',
   reuseDomNode: true,
-  render(domNode, config, handlers) {
-    ReactDOM.render(<div>{config}</div>, domNode, () => handlers.done());
+  render(domNode, { text }, handlers) {
+    ReactDOM.render(<div>{text}</div>, domNode, () => handlers.done());
     handlers.onDestroy(() => ReactDOM.unmountComponentAtNode(domNode));
   },
 });