Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to scale the y-axis of a histogram against a logarithmic scale #614

Closed
wants to merge 2 commits into from

Conversation

ukcrpb6
Copy link

@ukcrpb6 ukcrpb6 commented Oct 25, 2013

When a large outliers occur within the histogram it makes the small values within the graph difficult to discern, this is especially true when one or more series contribute.

To smooth these values and provide a readable displayed histogram scaling the graph using a logarithmic function is necessary.

The provided patch applies both configuration with configurable a base and the necessary scaling functions and tick functions to render the data and axis.

@vasily-kirichenko
Copy link

I merged this into the elasticsearch/master and the histograms don't show at all. I think it's because of huge changes in master.

I'm very much appreciate this functionality to be available in the elasticsearch/master. Are there any showstoppers to pull this request?

@griffinmyers
Copy link

+1

@edwindotcom
Copy link

didn't look at the commit - but really need this feature!

@sausagee
Copy link

sausagee commented May 8, 2014

+1

@ukcrpb6
Copy link
Author

ukcrpb6 commented May 11, 2014

Have rebased the PR changes upto the current kibana master

https://www.dropbox.com/s/a6vgknjjwg2nq59/Screenshot%202014-05-11%2015.18.53.png

@surfflash
Copy link

+1

@rashidkpc
Copy link
Contributor

Thanks for rebasing this, I'd love to get it into master. There's a couple issues currently:

  1. The default base is 1, which is always going to be undefined (Infinity)
  2. The y-axis formatting is off, values run into each other:

screen shot 2014-05-12 at 1 44 11 pm

@rashidkpc rashidkpc removed the 3.1.0 label May 12, 2014
@inthecloud247
Copy link

+1 :-)

@dbrgn
Copy link

dbrgn commented Jun 18, 2014

Definitely +1!

@maltekrupa
Copy link

+1

@dchichkov
Copy link

It'd be nice to get it into master.

@pinepain
Copy link

Must-have feature, are there any cons to have this PR merged in master?

@ukcrpb6
Copy link
Author

ukcrpb6 commented Jul 31, 2014

Played around with a few algorithms for computing the tick marks but most resulted in ugly choices.

Have simplified the ticks to just using powers rather than trying to squeeze more ticks in for most ranges of values this produces reasonable choices without cramping the graph.

screenshot 2014-07-31 22 04 12

screenshot 2014-07-31 22 06 56

@adampl
Copy link

adampl commented Aug 8, 2014

Could you please show how it copes with fractional or negative numbers?

@stig
Copy link

stig commented Aug 20, 2014

+1 would really like to see this!

@w33ble w33ble closed this Oct 6, 2014
@spalger
Copy link
Contributor

spalger commented Oct 6, 2014

Woops! Sorry about that! We recently replaced the master branch with Kibana 4. This action force closed all of the old pull requests against master. We will be reviewing these on a case-by-case basis and creating new tickets as necessary.

The good news is that many long requested features can be found in Kibana 4, and we're being entirely open about our roadmap. Check out the roadmap tickets (which we're still filling in) here.

If you're looking for the old Kibana 3 code you can find it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.