Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VyOS v1.4 support for BGP (T6892 & T6888 & T6822) #367

Merged
merged 38 commits into from
Dec 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
af91688
VyOS v1.4 support for BGP (T6892)
omnom62 Nov 28, 2024
c10b03a
WIP: chnages to scanners and facts for BGP on v1.4
omnom62 Nov 30, 2024
4e83507
scanners and facts modification to support as_numberless commands
omnom62 Dec 1, 2024
89c469f
remove optional regex groups
omnom62 Dec 1, 2024
bdf9104
VyOS v1.4 BGP system-as functionality
omnom62 Dec 1, 2024
68b9c33
bgp_af linter
omnom62 Dec 1, 2024
dc8dbbc
bgp_global mods and testing
omnom62 Dec 2, 2024
dc41dd2
bgp_global v.1.4 support
omnom62 Dec 2, 2024
6bf61fa
linter fixes
omnom62 Dec 2, 2024
c676bb1
bgp_global and bgp_af fixed 1.3 test cases
omnom62 Dec 3, 2024
f9645bd
unit tests for bgp modules for both versions
omnom62 Dec 3, 2024
ffc9533
obsolete stranzas removed from bgp_global for both versions
omnom62 Dec 3, 2024
e71c031
some typos removed
omnom62 Dec 4, 2024
9d1c0c4
bgp_global rst updates
omnom62 Dec 4, 2024
d12f92a
t6829 related draft changes
omnom62 Dec 5, 2024
730f22e
Draft changes to unit tests fot original set and t6888 updates
omnom62 Dec 5, 2024
08a3e41
changelog
omnom62 Dec 5, 2024
2d4aaac
D.R.Y for bgp_global and testmodule names
omnom62 Dec 6, 2024
0715d68
linter fixes
omnom62 Dec 6, 2024
c0a388c
fixtures for bgp_af options testts
omnom62 Dec 8, 2024
b2821bf
stranzas options processing
omnom62 Dec 11, 2024
d10dff4
T6888 bgp option test func and cases
omnom62 Dec 11, 2024
b51f014
clean-up draft code and update to rm_templates
omnom62 Dec 11, 2024
b92a8ef
v14 system-as change supported in conf and tests
omnom62 Dec 11, 2024
c777efd
T6822 BGP global passive bugfix
omnom62 Dec 13, 2024
61785d4
clean-up
omnom62 Dec 13, 2024
b37c770
T6829: update integration tests
gaige Dec 15, 2024
1d0a98d
T6829: fix integration tests for global
gaige Dec 15, 2024
c969dbd
T6829: fix integration tests for bgp_global
gaige Dec 15, 2024
08ef2a3
T6829: fix for 1.4 AF integration tests
gaige Dec 15, 2024
4dad478
T6829: fix unit tests after removing obsolete items
gaige Dec 15, 2024
40bba69
T6829: fix sanity test failures
gaige Dec 15, 2024
46a8323
T6829: fix documentation
gaige Dec 15, 2024
0f2fb47
Lint and comments are addressed
omnom62 Dec 16, 2024
dedeffd
rtt.yaml and fix to integration tests
omnom62 Dec 16, 2024
f7d9875
updated fragments for bgp_global
omnom62 Dec 16, 2024
07af8a8
lint fixes
omnom62 Dec 16, 2024
8f2b653
Merge branch 'main' into bgp_af_rework_t6829
omnom62 Dec 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Draft changes to unit tests fot original set and t6888 updates
  • Loading branch information
omnom62 committed Dec 5, 2024
commit 730f22e1144d2a514fd43304eda8c2aac8ef1f20
Original file line number Diff line number Diff line change
@@ -375,7 +375,8 @@ def __init__(self, lines=None, module=None):
re.VERBOSE,
),
"setval": _tmplt_bgp_af_network_generic,
"remval": "protocols bgp {{ as_number }} address-family {{ address_family.afi }}-unicast network {{ address_family.networks.prefix }} backdoor",
"remval": _tmplt_bgp_af_delete_network,
# "remval": "protocols bgp {{ as_number }} address-family {{ address_family.afi }}-unicast network {{ address_family.networks.prefix }} backdoor",
"compval": "address_family.networks.backdoor",
"result": {
"as_number": "{{ as_num }}",
omnom62 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -404,7 +404,8 @@ def __init__(self, lines=None, module=None):
re.VERBOSE,
),
"setval": _tmplt_bgp_af_network_generic,
"remval": "protocols bgp address-family {{ address_family.afi }}-unicast network {{ address_family.networks.prefix }} backdoor",
"remval": _tmplt_bgp_af_delete_network,
# "remval": "protocols bgp address-family {{ address_family.afi }}-unicast network {{ address_family.networks.prefix }} backdoor",
"compval": "address_family.networks.backdoor",
"result": {
"as_number": "{{ as_num }}",
gaige marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -283,6 +283,7 @@ def test_vyos_bgp_address_family_replaced(self):
"delete protocols bgp 65536 neighbor 203.0.113.5 address-family ipv6-unicast attribute-unchanged",
"delete protocols bgp 65536 neighbor 192.0.2.25 address-family ipv4-unicast soft-reconfiguration",
"delete protocols bgp 65536 address-family ipv6-unicast redistribute ripng",
# "delete protocols bgp 65536 address-family ipv4-unicast network 192.2.13.0/24 backdoor",
"delete protocols bgp 65536 address-family ipv4-unicast network 192.2.13.0/24",
"set protocols bgp 65536 address-family ipv4-unicast aggregate-address 192.0.2.0/24 summary-only",
"set protocols bgp 65536 address-family ipv6-unicast redistribute ospfv3 metric 20",
@@ -383,6 +384,7 @@ def test_vyos_bgp_address_family_overridden(self):
"delete protocols bgp 65536 address-family ipv6-unicast redistribute ripng",
"delete protocols bgp 65536 address-family ipv4 aggregate-address",
"delete protocols bgp 65536 address-family ipv4-unicast network 192.2.13.0/24",
# "delete protocols bgp 65536 address-family ipv4-unicast network 192.2.13.0/24 backdoor",
"set protocols bgp 65536 address-family ipv6-unicast redistribute ospfv3 metric 20",
"set protocols bgp 65536 neighbor 192.10.21.25 address-family ipv4-unicast route-map import map01",
"set protocols bgp 65536 neighbor 192.10.21.25 address-family ipv6-unicast distribute-list export 10",
omnom62 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -284,6 +284,7 @@ def test_vyos_bgp_address_family_replaced(self):
"delete protocols bgp neighbor 192.0.2.25 address-family ipv4-unicast soft-reconfiguration",
"delete protocols bgp address-family ipv6-unicast redistribute ripng",
"delete protocols bgp address-family ipv4-unicast network 192.2.13.0/24",
# "delete protocols bgp address-family ipv4-unicast network 192.2.13.0/24 backdoor",
"set protocols bgp address-family ipv4-unicast aggregate-address 192.0.2.0/24 summary-only",
"set protocols bgp address-family ipv6-unicast redistribute ospfv3 metric 20",
"set protocols bgp neighbor 192.10.21.25 address-family ipv4-unicast route-map import map01",
@@ -383,6 +384,7 @@ def test_vyos_bgp_address_family_overridden(self):
"delete protocols bgp address-family ipv6-unicast redistribute ripng",
"delete protocols bgp address-family ipv4 aggregate-address",
"delete protocols bgp address-family ipv4-unicast network 192.2.13.0/24",
# "delete protocols bgp address-family ipv4-unicast network 192.2.13.0/24 backdoor",
"set protocols bgp address-family ipv6-unicast redistribute ospfv3 metric 20",
"set protocols bgp neighbor 192.10.21.25 address-family ipv4-unicast route-map import map01",
"set protocols bgp neighbor 192.10.21.25 address-family ipv6-unicast distribute-list export 10",
Loading