VyOS v1.4 support for BGP (T6892 & T6888 & T6822)

[omnom62]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):
  Breaking changes to parsers, generate_command logic to ensure the correct processing for differences between OSes, obsolete provisioning is removed from bgp_global, added extra unit tests, added logic to differentiate between OS versions

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Test results

• Sanity tests passed
• Unit tests passed

Tested against VyOS versions:

• 1.2
• 1.3.8
• 1.4-rolling-202201010100
• 1.5

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the ansible sanity and unit tests
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added unit tests to cover my changes
• I have added a file to changelogs/fragments to describe the changes

[gaige]

Looking good so far. Some questions and recommendations here.

[gaige]

It’s worthwhile to start adding the release notes, including comments about every user-noticeable change and making sure these are designated as Breaking Changes.

[gaige]

It’s worthwhile to start adding the release notes, including comments about every user-noticeable change and making sure these are designated as Breaking Changes.

For clarity here, I was meaning adding the changeling file for this, which will be incorporated into the release notes, not changes directly to the README.md

[omnom62]

It’s worthwhile to start adding the release notes, including comments about every user-noticeable change and making sure these are designated as Breaking Changes.

For clarity here, I was meaning adding the changeling file for this, which will be incorporated into the release notes, not changes directly to the README.md

I am adding to changelog/fragments/<module_name>.yaml

[gaige]

Looks good! Glad to see we've got unit and integration tests working as well!