Feat: Design System Unification (2) #2390
Conversation
renatamottam
requested review from
hellofanny and
lucasfp13
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
All .mdx files changes should be updated on the dev portal doc @mariana-caetano
There was a problem hiding this comment.
Thanks, @renatamottam!! I will work on this in the EDU-13056.
There was a problem hiding this comment.
@renatamottam @mariana-caetano
btw, I don't think this could be classified as a breaking change, but since we are renaming some tokens and base styles, I think it would be a good idea to make a release, at least here on GitHub. We won't have the documentation updates launched together, right? So, I'll make the release after the new version of the framework is ready. Does that sound okay?
There was a problem hiding this comment.
@hellofanny agreed!
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -32,7 +32,7 @@ | |||
| // Title | |||
| --fs-toast-title-size : var(--fs-text-size-body); | |||
| --fs-toast-title-weight : var(--fs-text-weight-bold); | |||
| --fs-toast-title-line-height : var(--fs-scale); | |||
| --fs-toast-title-line-height : 1.2; | |||
There was a problem hiding this comment.
suggestion: @renatamottam I noticed that we are using this same line-height:1.2 value for other components too, WDYT about adding it as a global token?
There was a problem hiding this comment.
I love this idea, I'm gonna create a task for it on our backlog ✨
packages/core/src/components/sections/ProductGallery/section.module.scss
Show resolved
Hide resolved
What's the purpose of this pull request?
This PR updates the Brandless to the new design foundations from VTEX. I also made a small improvement on Payment Methods icons by fixing existed ones and adding new methods.
Major changes:
Minor changes:
InputFieldlabel centered vertical position for inputs with custom heightProductCardOut-of-stock stylesQuantitySelectorborder-radius declarationProductPricestyle import onProductGalleryHow to test it?
You should see changes on typography, colors and icons.
https://starter-git-feat-design-system-unification-faststore.vercel.app/
Starter PR
vtex-sites/starter.store#501