Feat: Design System Unification #2120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
renatamottam
force-pushed
the
feat/design-system-unification
branch
from
32a0910 to
7a9504d
Compare
renatamottam
force-pushed
the
feat/design-system-unification
branch
from
39814f6 to
b093ba3
Compare
hellofanny
reviewed
Jul 19, 2024
| @@ -205,13 +205,19 @@ export const propsInputField = [ | |||
| #### Label | |||
|
|
|||
| <TokenTable> | |||
| <TokenRow token="--fs-input-label-padding" value="0 var(--fs-spacing-2)" /> | |||
| <TokenRow token="--fs-input-field-label-padding" value="0 var(--fs-spacing-2)" /> | |||
There was a problem hiding this comment.
todo: We'll have to update in developer portal doc
There was a problem hiding this comment.
@renatamottam since we migrate all the docs to portal, we'll need to apply all the changes made on this PR there.
cc: @mariana-caetano
|
@renatamottam Renatinha can you please open a preview PR in starter just in case? Thanks |
hellofanny
reviewed
Jul 19, 2024
…tex/faststore into feat/design-system-unification
This was referenced Jul 24, 2024
renatamottam
added a commit
that referenced
this pull request
Jul 29, 2024
> Commits migrated from #2120 to fix unwanted merge ## What's the purpose of this pull request? This PR updates the Brandless to the new design foundations from VTEX. I also made a small improvement on Payment Methods icons by fixing existed ones and adding new methods. **Major changes:** - [x] Updates type scale **Minor changes:** - [x] Fix `InputField` label centered vertical position for inputs with custom height - [x] Fix payment methods icons - [x] Fix `ProductCard` Out-of-stock styles - [x] Fix `QuantitySelector` border-radius declaration - [x] Update all "Lato" font declaration to "Inter" - [x] Add missing `ProductPrice` style import on `ProductGallery` |Before|After| |-|-| |<img width="937" alt="Screenshot 2023-11-21 at 10 11 13" src="https://github.com/vtex/faststore/assets/11613011/190f6580-c292-4d84-86f6-8c04e1723eb4">|<img width="937" alt="Screenshot 2023-11-21 at 10 10 48" src="https://github.com/vtex/faststore/assets/11613011/fdf8b937-78b6-4e28-9b6e-b780769dee39">| |<img width="242" alt="image" src="https://github.com/vtex/faststore/assets/11613011/35641092-13d1-484b-8855-38bfba7349b1">|<img width="242" alt="image" src="https://github.com/vtex/faststore/assets/11613011/c2cf1e7f-a228-4092-982a-2af6360a8229">| ## How to test it? You should see changes on typography, colors and icons. https://starter-git-feat-design-system-unification-faststore.vercel.app/ ## Starter PR vtex-sites/starter.store#501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR updates the Brandless to the new design foundations from VTEX. I also made a small improvement on Payment Methods icons by fixing existed ones and adding new methods.
Major changes:
Minor changes:
InputFieldlabel centered vertical position for inputs with custom heightProductCardOut-of-stock stylesQuantitySelectorborder-radius declarationHow to test it?
You should see changes on typography, colors and icons.
https://starter-git-feat-design-system-unification-faststore.vercel.app/
Starter PR
vtex-sites/starter.store#501