refactor: Extract CartItem component from the starter
#1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c5aba36:
|
filipewl
force-pushed
the
refactor/fs-361-cart-item
branch
from
96e35ca to
c5aba36
Compare
filipewl
referenced
this pull request
in vtex-sites/gatsby.store
Sep 12, 2022
Extract the `CartItem` component from our starter to `@faststore/ui`. Visit https://sfj-4a90f81--nextjs.preview.vtex.app/4k-philips-monitor-99988213/p and add a product to the cart. A `CartItem` component will be rendered inside the mini-cart sidebar. It should look and work the same as before. <img src="https://user-images.githubusercontent.com/381395/189658104-c64012ee-dd16-4ce0-a2bc-4535e8bec5d5.gif" width="50%" alt="Before and after changes" /> - https://github.com/vtex/faststore/pull/1461\
filipewl
added a commit
to vtex-sites/gatsby.store
that referenced
this pull request
Sep 13, 2022
## What's the purpose of this pull request? Extract the `CartItem` component from our starter to `@faststore/ui`. ## How to test it? Visit https://sfj-4a90f81--nextjs.preview.vtex.app/4k-philips-monitor-99988213/p and add a product to the cart. A `CartItem` component will be rendered inside the mini-cart sidebar. It should look and work the same as before. <img src="https://user-images.githubusercontent.com/381395/189658104-c64012ee-dd16-4ce0-a2bc-4535e8bec5d5.gif" width="50%" alt="Before and after changes" /> ## References - vtex/faststore#1461
gvc
referenced
this pull request
Feb 7, 2023
## What's the purpose of this pull request? Extract the `CartItem` component from our starter to `@faststore/ui`. ## How to test it? Visit https://sfj-4a90f81--nextjs.preview.vtex.app/4k-philips-monitor-99988213/p and add a product to the cart. A `CartItem` component will be rendered inside the mini-cart sidebar. It should look and work the same as before. <img src="https://user-images.githubusercontent.com/381395/189658104-c64012ee-dd16-4ce0-a2bc-4535e8bec5d5.gif" width="50%" alt="Before and after changes" /> ## References - https://github.com/vtex/faststore/pull/1461\
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Extract the
CartItemcomponent from our starter to@faststore/ui.How to test it?
Run
yarn storybookand check the newCartItementry at http://localhost:6006/?path=/story/molecules-cartitem--default.Starters Deploy Preview
Check https://sfj-4a90f81--nextjs.preview.vtex.app/4k-philips-monitor-99988213/p from https://github.com/vtex-sites/nextjs.store/pull/239. Add a product to the min-cart and you should see the
CartItembeing rendered in the sidebar.References