refactor: Extract CartItem from the starter to @faststore/ui
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the `CartItem` component from our starter to `@faststore/ui`. Visit https://sfj-4a90f81--nextjs.preview.vtex.app/4k-philips-monitor-99988213/p and add a product to the cart. A `CartItem` component will be rendered inside the mini-cart sidebar. It should look and work the same as before. <img src="https://user-images.githubusercontent.com/381395/189658104-c64012ee-dd16-4ce0-a2bc-4535e8bec5d5.gif" width="50%" alt="Before and after changes" /> - https://github.com/vtex/faststore/pull/1461\
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 9d5f6d5
|
filipewl
changed the title
CartItem from the starter to @faststore/ui (#239)CartItem from the starter to @faststore/ui
|
Tested on https://preview-198--gatsby.preview.vtex.app/apple-magic-mouse-99988212/p and it looks fine!
Merging this ahead since it's been approved in https://github.com/vtex-sites/nextjs.store/pull/239. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://github.com/vtex-sites/nextjs.store/pull/239.