feat: Add ProductTitle Molecule #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2911f4f:
|
filipewl
approved these changes
Jul 27, 2022
packages/ui/src/molecules/ProductTitle/stories/ProductTitle.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Filipe W. Lima <filipe.lima@vtex.com.br>
hellofanny
reviewed
Jul 28, 2022
Co-authored-by: Fanny Chien <fannychienn@gmail.com>
hellofanny
approved these changes
Jul 29, 2022
| [data-fs-product-title] [data-fs-product-title-addendum] { | ||
| margin-top: 1rem; | ||
| color: #5d666f; | ||
| } |
There was a problem hiding this comment.
Github is complaining about the new line.
| testId?: string | ||
| } | ||
|
|
||
| function ProductTitle({ title, label, refTag= "Ref.: ",refNumber, testId= 'store-product-title', ...otherProps }: ProductTitleProps) { |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com
What's the purpose of this pull request?
This PR is part of the Component Placement project, to bring some components from starters.
How it works?
This PR places the
ProductTitlecomponent to Faststore with new data-attributes.How to test it?
Component in FastStore
Component in BaseStore
Tests will be implemented in next step of Component Placement
Starters Deploy Preview
References
Move ProductTitle component to FastStore