Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ProductTitle import from faststore #164

Merged
merged 9 commits into from
Aug 2, 2022

Conversation

ArthurTriis1
Copy link
Contributor

@ArthurTriis1 ArthurTriis1 commented Aug 1, 2022

Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com## What's the purpose of this pull request?

This PR is part of the Component Placement project, to bring some components from starters.

How does it work?

This PR will add the ProductTitle to gatsby.store from vtex/faststore#1418.

How to test it?

  • Nothing should change visually on the component.
PDP
Screen Shot 2022-08-01 at 14 33 23

Checklist

You may erase this after checking them all ;)

PR Title and Commit Messages

PR Description

  • Added a label according to the PR goal - Breaking change, Enhancement, Bug or Chore.
  • Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g., ComponentName component.
  • Identified the function or parameter in the PR - If applicable. E.g., useWindowDimensions hook.

Documentation

  • PR description
  • Added to/Updated the Storybook - if applicable.
  • For documentation changes, ping @ carolinamenezes, @ PedroAntunesCosta or @ Mariana-Caetano to review and update.

Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
@vercel
Copy link

vercel bot commented Aug 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gatsby-store-storybook ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 1:29PM (UTC)

@ArthurTriis1 ArthurTriis1 changed the title feat: Add ProductTitle import from faststore FEAT: Add ProductTitle import from faststore Aug 1, 2022
@vtex-sites
Copy link

vtex-sites bot commented Aug 1, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://preview-164--gatsby.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 7d4e30f

@ArthurTriis1 ArthurTriis1 added the Features New feature or request label Aug 1, 2022
@ArthurTriis1 ArthurTriis1 requested a review from filipewl August 1, 2022 17:36
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
@ArthurTriis1 ArthurTriis1 changed the title FEAT: Add ProductTitle import from faststore feat: Add ProductTitle import from faststore Aug 1, 2022
@ArthurTriis1 ArthurTriis1 self-assigned this Aug 1, 2022
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
@vtex-sites
Copy link

vtex-sites bot commented Aug 1, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 7d4e30f

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse/p
📎   /office

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
@ArthurTriis1 ArthurTriis1 merged commit 5638fb2 into main Aug 2, 2022
@ArthurTriis1 ArthurTriis1 deleted the FS-358-feat/Add-product-title-from-faststore branch August 2, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants