Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Add session mutation #1176

Merged
merged 8 commits into from
Mar 24, 2022
Merged

feat(api): Add session mutation #1176

merged 8 commits into from
Mar 24, 2022

Conversation

igorbrasileiro
Copy link
Contributor

@igorbrasileiro igorbrasileiro commented Mar 17, 2022 •
edited
Loading

What's the purpose of this pull request?

This PR adds the session query.

type StoreSession {
  channel: String
  country: String
  postalCode: String
}

input IStoreSession {
  channel: String
  country: String
    postalCode: String
}

type Mutation {
 """..."""
  session(session: IStoreSession!): StoreSession!
}

How it works?

The Session returns only the channel and the country. This is a partial Session, just to allow implement the VTEX regionalization that needs the regionId, that's is inside the channel.

How to test it?

base.store Deploy Preview

vtex-sites/base.store#392

References

@igorbrasileiro igorbrasileiro requested a review from a team as a code owner March 17, 2022 16:13
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 577881c:

Sandbox Source
Store UI Typescript Configuration

@igorbrasileiro igorbrasileiro self-assigned this Mar 17, 2022
emersonlaurentino
emersonlaurentino reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@emersonlaurentino emersonlaurentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why getTypeDefs should return the Platform?

packages/api/src/platforms/vtex/customTypeDefs/query.graphql Outdated Show resolved Hide resolved
victorhmp
victorhmp approved these changes Mar 17, 2022
View reviewed changes
packages/api/src/platforms/vtex/resolvers/query.ts Outdated Show resolved Hide resolved
packages/api/src/platforms/vtex/resolvers/query.ts Outdated Show resolved Hide resolved
packages/api/src/typeDefs/index.ts Outdated Show resolved Hide resolved
@igorbrasileiro igorbrasileiro changed the title feat(api): Add custom typeDefs for VTEX platform and Region resolver feat(api): Add session query Mar 17, 2022
@igorbrasileiro igorbrasileiro changed the title feat(api): Add session query feat(api): Add session mutation Mar 22, 2022
lariciamota
lariciamota reviewed Mar 23, 2022
View reviewed changes
packages/api/src/__generated__/schema.ts
Comment on lines +52 to +55
channel?: Maybe<Scalars['String']>;
country?: Maybe<Scalars['String']>;
postalCode?: Maybe<Scalars['String']>;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

packages/api/src/platforms/vtex/resolvers/session.ts Outdated

channelParser.updateChannel({ regionId: regionData?.[0]?.id })

return { ...session, channel: channelParser.stringify() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why you chose to create this stringify function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the channel for all platforms is a string that should be handled only on the backend, for the front end is only a string.

tlgimenes
tlgimenes approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@igorbrasileiro igorbrasileiro merged commit 0306167 into master Mar 24, 2022
@igorbrasileiro igorbrasileiro deleted the feat/region-query branch March 24, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlgimenes tlgimenes tlgimenes approved these changes

@lariciamota lariciamota lariciamota approved these changes

@victorhmp victorhmp victorhmp approved these changes

@emersonlaurentino emersonlaurentino Awaiting requested review from emersonlaurentino

Assignees

@igorbrasileiro igorbrasileiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@igorbrasileiro @tlgimenes @emersonlaurentino @lariciamota @victorhmp