This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
feat: Add session query and run session query after change postal code #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for basestore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 10m PerformanceLighthouse report
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-392--base.preview.vtex.app |
igorbrasileiro
commented
Mar 16, 2022
igorbrasileiro
force-pushed
the
feat/region-query
branch
from
309a8bd to
65e9324
Compare
igorbrasileiro
commented
Mar 17, 2022
package.json
Outdated
| @@ -27,9 +27,10 @@ | |||
| "@envelop/graphql-jit": "^1.1.1", | |||
| "@envelop/parser-cache": "^2.2.0", | |||
| "@envelop/validation-cache": "^2.2.0", | |||
| "@faststore/api": "^1.6.7", | |||
| "@faststore/api": "https://pkg.csb.dev/vtex/faststore/commit/a83409a6/@faststore/api", | |||
There was a problem hiding this comment.
Remember to fix it.
igorbrasileiro
force-pushed
the
feat/region-query
branch
from
6943562 to
5e5844c
Compare
igorbrasileiro
changed the title
tlgimenes
reviewed
Mar 18, 2022
| @@ -29,7 +29,7 @@ export const useProduct = <T extends BrowserProductQueryQuery>( | |||
| return { | |||
| locator: [ | |||
| { key: 'id', value: productID }, | |||
| { key: 'channel', value: channel }, | |||
| { key: 'channel', value: JSON.parse(channel).salesChannel }, | |||
There was a problem hiding this comment.
This parsing should happen on the api, right?
There was a problem hiding this comment.
Sure, but the api doesn't handle it, now.
tlgimenes
reviewed
Mar 18, 2022
tlgimenes
reviewed
Mar 18, 2022
tlgimenes
reviewed
Mar 18, 2022
tlgimenes
reviewed
Mar 18, 2022
igorbrasileiro
force-pushed
the
feat/region-query
branch
2 times, most recently
from
92f9d23 to
3d7fb35
Compare
igorbrasileiro
force-pushed
the
feat/region-query
branch
3 times, most recently
from
fd14337 to
e657682
Compare
tlgimenes
reviewed
Mar 23, 2022
igorbrasileiro
force-pushed
the
feat/region-query
branch
4 times, most recently
from
3b89955 to
a1596fa
Compare
|
@tlgimenes Fixed all comments |
igorbrasileiro
force-pushed
the
feat/region-query
branch
from
a1596fa to
4e4972d
Compare
lariciamota
approved these changes
Mar 24, 2022
igorbrasileiro
force-pushed
the
feat/region-query
branch
5 times, most recently
from
c119b0f to
20a2d0f
Compare
|
@tlgimenes can i merge it?! Is ok for you, right now? |
igorbrasileiro
force-pushed
the
feat/region-query
branch
from
20a2d0f to
7edaf5f
Compare
victorhmp
approved these changes
Mar 28, 2022
Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
igorbrasileiro
force-pushed
the
feat/region-query
branch
from
7edaf5f to
1a2dcd6
Compare
|
Page result - https://base.vtex.app/
Page result - https://sfj-1a2dcd6--base.preview.vtex.app/
|
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PRs adds the session region for VTEX platform and runs the session query when the postal code changes.
How does it work?
When the user changes the postal code, fetches a new channel that contains regionId as value.
How to test it?
Set a valid postal code in the postal code and press
EnterAlso, test the search, add to cart.
References
Checklist