Rspec tests (and fixes) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 21, 2013 22:14
Resolves #65
Before this change, vhost_ssl_header would merge
"ssl" with any listen options, e.g.:
listen *:443 ssldefault;
when listen_options => 'default'.
correctly sets www_root in the vhost_header template
|
This is fantastic, and will help with some much needed TLC on the module internals. Thanks so much for taking the time! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Rspec tests (and fixes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just finished a bit of a personal project - rspec tests for this module!
I didn't have much experience with rspec when I started so these are certainly not perfect but they give very good coverage over the module's functionality and config file output. They're modelled on the puppetlabs/apache specs.
The first commit has tests for the current v0.0.6 version of the module, and the subsequent commits contain various isolated fixes for issues I found. I can provide more detail in each commit's description if required, but none will have any effect on current users other than squashing bugs (this is verified by the tests!) except changing the template test for
ipv6_enableto a boolean check instead of checking a string (if people are setting this to'false'instead offalsefor example the behaviour for them will change - having said that the module is now working according to the inline documentation at https://github.com/jfryman/puppet-nginx/blob/master/manifests/resource/vhost.pp#L16).Anyway I appreciate any and all feedback and hope this gets merged, and that it helps to maintain the quality of the module going forward.
Resolves #65
Fixes #186