Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(regression) nested server directives when using SSL vhost #186

Closed
3flex opened this issue Nov 19, 2013 · 3 comments · Fixed by #188
Closed

(regression) nested server directives when using SSL vhost #186

3flex opened this issue Nov 19, 2013 · 3 comments · Fixed by #188

Comments

@3flex
Copy link
Contributor

3flex commented Nov 19, 2013

PR #184 changed the priority of the vhost file fragments, so the templates will be combined in this order when SSL vhost is used (first number is the priority):

  • 001: nginx/vhost/vhost_header.erb
  • 300: nginx/vhost/vhost_ssl_header.erb
  • 699: nginx/vhost/vhost_footer.erb
  • 999: nginx/vhost/vhost_ssl_footer.erb

The server directive and the relevant closing braces are now:

#vhost_header.erb
server {

#vhost_ssl_header.erb
server {

#vhost_footer.erb
}

#vhost_ssl_footer
}

This creates a nested server directive which is invalid.

@abraham1901
Copy link
Contributor

Hmm. You're right, but to undo the changes mean return error. We need a different implementation priorities.
I'm trying rewrite it.

@3flex
Copy link
Contributor Author

3flex commented Nov 20, 2013

What error are you receiving? Could you include a copy of your manifest that's returning an error? If you outline the problem you're actually trying to solve because it will make working out a solution easier, in a way that won't cause regressions.

@abraham1901
Copy link
Contributor

Sorry, it's my error.
I forgot to specify the option ssl => true for my location.
ssl priority algorithm right:
$ssl_priority = $priority + 300

ohohoh, I need more sleep ...
Sprinkle ashes.

And need changes user priority for location s/400-499, 501-599/401-499, 501-599/ in manual.

James, please merge this fix.

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Oct 23, 2017
This reverts commit 5ee2f65.

Fixes voxpupuli#186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants