Revert rubocop TargetRubyVersion back to 1.9 #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Jan 17, 2020
llowder
approved these changes
Jan 17, 2020
Puppet Server 5 isn't fully EOL until Nov 2020. By default it uses jruby 1.7 which is only Ruby 1.9 compatible. Targetting ruby 2.1 already broke one module. See voxpupuli/puppet-firewalld#250 Alternatively, we could tweak the various cops to try to remain compatible. But why? This doesn't provide value over just setting `TargetRubyVersion` to what we need it to be. When puppet 5 goes EOL, we can bump this back up and move to a newer version of rubocop too. Until then, I don't think we're really missing out all that much.
alexjfisher
force-pushed
the
rubocop_target_version
branch
from
751e028 to
a13015c
Compare
|
Updated with comment as suggested by @baurmatt on slack. |
baurmatt
approved these changes
Jan 17, 2020
dhollinger
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet Server 5 isn't fully EOL until Nov 2020. By default it uses
jruby 1.7 which is only Ruby 1.9 compatible. Targetting ruby 2.1
already broke one module. See voxpupuli/puppet-firewalld#250
Alternatively, we could tweak the various cops to try to remain
compatible. But why? This doesn't provide value over just setting
TargetRubyVersionto what we need it to be.When puppet 5 goes EOL, we can bump this back up and move to a newer
version of rubocop too. Until then, I don't think we're really missing
out all that much.