Skip to content

Commit

Permalink
Revert rubocop TargetRubyVersion back to 1.9
Browse files Browse the repository at this point in the history
Puppet Server 5 isn't fully EOL until Nov 2020.  By default it uses
jruby 1.7 which is only Ruby 1.9 compatible.  Targetting ruby 2.1
already broke one module.  See voxpupuli/puppet-firewalld#250

Alternatively, we could tweak the various cops to try to remain
compatible.  But why?  This doesn't provide value over just setting
`TargetRubyVersion` to what we need it to be.

When puppet 5 goes EOL, we can bump this back up and move to a newer
version of rubocop too. Until then, I don't think we're really missing
out all that much.
  • Loading branch information
alexjfisher committed Jan 17, 2020
1 parent c6c6ae2 commit a13015c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion moduleroot/.rubocop.yml.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
require: rubocop-rspec
AllCops:
TargetRubyVersion: 2.1
# Puppet Server 5 defaults to jruby 1.7 so TargetRubyVersion must stay at 1.9 until we drop support for puppet 5
TargetRubyVersion: 1.9
Include:
- ./**/*.rb
Exclude:
Expand Down

0 comments on commit a13015c

Please sign in to comment.