Use shorter directory names for beaker-hostgenerator #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Beaker setfile doesn't exist, Beaker calls beaker-hostgenerator and sets the :hosts_file_generated option. These directory names can become very long and in some cases exceed some limits when used with vagrant-libvirt. This only uses the hostnames and discards all options passed. This can break some scenarios where a host is reused and a user may assume that passing in new options changes the host.
This was referenced Jan 27, 2024
|
voxpupuli/puppet-swap_file#3 now using this patch. |
traylenator
approved these changes
Apr 4, 2024
|
Merging since the RuboCop failure is also present in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Beaker setfile doesn't exist, Beaker calls beaker-hostgenerator and sets the :hosts_file_generated option. These directory names can become very long and in some cases exceed some limits when used with vagrant-libvirt.
This only uses the hostnames and discards all options passed. This can break some scenarios where a host is reused and a user may assume that passing in new options changes the host.
Currently a draft to test if it resolves the
Call to virDomainCreateWithFlags failed: Invalid machine nameerror reported in voxpupuli/gha-puppet#49 (comment)