Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out invalid bins when loading package manifest #997

Merged
merged 1 commit into from
May 3, 2022
Merged

Filter out invalid bins when loading package manifest #997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/volta-core/src/tool/package/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,12 @@ mod serde_bins {
{
let mut bins = Vec::new();
while let Some((name, _)) = access.next_entry::<String, String>()? {
bins.push(name);
// Bin names that include path separators are invalid, as they would then point to
// other locations on the filesystem. To match the behavior of npm & Yarn, we
// filter those values out of the list of bins.
if !name.contains(&['/', '\\'][..]) {
bins.push(name);
}
}
Ok(bins)
}
Expand Down