Filter out invalid bins when loading package manifest #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
bin
hash inpackage.json
, both npm and Yarn handle it by skipping over that entry, but Volta tries to create shims and then fails with an error.Changes
bin
hash to exclude any names that contain path separators (/
and\
).Tested
@ethersphere/swarm-cli
) and confirmed that it failed before the change and succeeded afterwards.package.json
during a global install, so I was only able to reproduce the failure using npm 7.